load-from-file: Updates to improve reliability of large .parm loads#112
Open
vielster wants to merge 1 commit intodronecan:masterfrom
Open
load-from-file: Updates to improve reliability of large .parm loads#112vielster wants to merge 1 commit intodronecan:masterfrom
vielster wants to merge 1 commit intodronecan:masterfrom
Conversation
The present implementation of do_load_from_file has a few performance
issues.
1) All ConfigGetSet() requests are queued as fast as possible, and do
not give time for the downstream system to even respond before the
next transaction is sent.
2) Even thought the index is known for each parameter in the table
the name based request for setting is _always_ used. This causes
very heavy bus loading, expecially when combined with (1)
This commit make the following core updates:
1) Stores the index in the param set such that it can be utilized
later for setting parameters.
2) Queues the request transactions at 20ms increments to give the
downstream unit a chance to process the request before sending
the next.
Additionally in this commit, the fetch speed was increased from 100ms
intervals between fetching parameters to 10ms.
The 10ms and 20ms settings could be added to the application config to
allow some tuning/tweaking on a per user basis, but for now, all tests
show these are sufficient values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The present implementation of do_load_from_file has a few performance issues.
not give time for the downstream system to even respond before the
next transaction is sent.
the name based request for setting is always used. This causes
very heavy bus loading, expecially when combined with (1)
This commit make the following core updates:
later for setting parameters.
downstream unit a chance to process the request before sending
the next.
Additionally in this commit, the fetch speed was increased from 100ms intervals between fetching parameters to 10ms.
The 10ms and 20ms settings could be added to the application config to allow some tuning/tweaking on a per user basis, but for now, all tests show these are sufficient values.