Static files: set Expires header from configured cache time#2515
Open
ericel wants to merge 1 commit into
Open
Conversation
ericel
added a commit
to ericel/drogon
that referenced
this pull request
May 10, 2026
Member
|
@ericel Thanks for your patch, please rebase onto the last version. |
ericel
force-pushed
the
fix/static-expires-header
branch
from
07195d1 to
677593f
Compare
Author
|
Rebased onto latest \ and force-pushed. This PR now contains only the Expires-header fix on top of current upstream. |
Author
|
Rebased onto latest master and force-pushed. This PR now contains only the Expires-header fix on top of current upstream. |
ericel
force-pushed
the
fix/static-expires-header
branch
from
677593f to
78ecd24
Compare
ericel
force-pushed
the
fix/static-expires-header
branch
from
78ecd24 to
2674e19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded Expires header (epoch) with a computed Expires based on StaticFileRouter::staticFilesCacheTime_. This allows proper caching of static files when static file cache time is set.\n\nFiles changed:\n- lib/src/StaticFileRouter.cc\n\nBehavior: Expires is set to now + staticFilesCacheTime_ seconds (only when >0).