Skip to content

Removed stale Drupal scaffold exclusions from 'composer.json'.#2448

Merged
AlexSkrypnyk merged 2 commits intomainfrom
feature/scaffold-file-audit
Apr 2, 2026
Merged

Removed stale Drupal scaffold exclusions from 'composer.json'.#2448
AlexSkrypnyk merged 2 commits intomainfrom
feature/scaffold-file-audit

Conversation

@AlexSkrypnyk
Copy link
Copy Markdown
Member

@AlexSkrypnyk AlexSkrypnyk commented Apr 2, 2026

Summary

  • Removed 4 stale Drupal scaffold exclusions from composer.json that no longer exist in Drupal core's scaffold file mapping
  • Updated installer test snapshots to reflect the change

Details

The following scaffold exclusions were stale and have been removed:

Entry Reason
[web-root]/.editorconfig Never existed in core scaffold; core only ships [project-root]/.editorconfig
[web-root]/.gitattributes Never existed in core scaffold; core only ships [project-root]/.gitattributes
[web-root]/README.txt Core maps README.md, not .txt
[web-root]/web.config Removed from core scaffold in Drupal 11.0.0

Keeping exclusions for files that are not in core's scaffold mapping has no practical effect, but it adds noise and may mislead developers into thinking these files are managed by the scaffold system.

Test plan

  • Verify composer install completes without scaffold warnings
  • Confirm no files are unexpectedly created or removed in web/ after a fresh install
  • Installer snapshot tests pass

Summary by CodeRabbit

  • Chores
    • Updated Drupal scaffold file mappings configuration to exclude web-root support files (.editorconfig, .gitattributes, README.txt, web.config) from automatic scaffolding.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f479c9de-16d1-41d9-87e0-6bbd81af05d3

📥 Commits

Reviewing files that changed from the base of the PR and between b6e739e and 4a56834.

⛔ Files ignored due to path filters (4)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/hosting_acquia/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/starter_drupal_cms_profile/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (1)
  • composer.json

Walkthrough

This pull request modifies the Drupal scaffold configuration in composer.json by removing several web-root file mappings, including .editorconfig, .gitattributes, README.txt, web.config, and update.php from automatic scaffolding during installation.

Changes

Cohort / File(s) Summary
Drupal Scaffold Configuration
composer.json
Removed [web-root]/ file mappings for .editorconfig, .gitattributes, README.txt, web.config, and update.php from the extra.drupal-scaffold.file-mapping configuration section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Hop skip away, old scaffold files,
We trim the roots with Drupal smiles,
No more .editorconfig clone,
These web-roots now stand on their own! 🌱

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing stale Drupal scaffold exclusions from composer.json, which is precisely what the changeset accomplishes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/scaffold-file-audit

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.53% (201/204)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk
Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.53% (201/204)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.42%. Comparing base (b6e739e) to head (4a56834).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2448      +/-   ##
==========================================
- Coverage   79.88%   79.42%   -0.47%     
==========================================
  Files         128      121       -7     
  Lines        6861     6702     -159     
  Branches       47        3      -44     
==========================================
- Hits         5481     5323     -158     
+ Misses       1380     1379       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk merged commit 827a19a into main Apr 2, 2026
30 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/scaffold-file-audit branch April 2, 2026 09:58
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant