Removed stale Drupal scaffold exclusions from 'composer.json'.#2448
Removed stale Drupal scaffold exclusions from 'composer.json'.#2448AlexSkrypnyk merged 2 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
WalkthroughThis pull request modifies the Drupal scaffold configuration in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2448 +/- ##
==========================================
- Coverage 79.88% 79.42% -0.47%
==========================================
Files 128 121 -7
Lines 6861 6702 -159
Branches 47 3 -44
==========================================
- Hits 5481 5323 -158
+ Misses 1380 1379 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
composer.jsonthat no longer exist in Drupal core's scaffold file mappingDetails
The following scaffold exclusions were stale and have been removed:
[web-root]/.editorconfig[project-root]/.editorconfig[web-root]/.gitattributes[project-root]/.gitattributes[web-root]/README.txtREADME.md, not.txt[web-root]/web.configKeeping exclusions for files that are not in core's scaffold mapping has no practical effect, but it adds noise and may mislead developers into thinking these files are managed by the scaffold system.
Test plan
composer installcompletes without scaffold warningsweb/after a fresh installSummary by CodeRabbit