Improved Behat tests with correct Gherkin structure and JS screenshot probing.#2447
Merged
AlexSkrypnyk merged 2 commits intomainfrom Apr 2, 2026
Merged
Improved Behat tests with correct Gherkin structure and JS screenshot probing.#2447AlexSkrypnyk merged 2 commits intomainfrom
AlexSkrypnyk merged 2 commits intomainfrom
Conversation
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2447 +/- ##
==========================================
- Coverage 79.88% 79.42% -0.47%
==========================================
Files 128 121 -7
Lines 6861 6702 -159
Branches 47 3 -44
==========================================
- Hits 5481 5323 -158
+ Misses 1380 1379 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given/When/Thenstructure — scenarios previously started withGiven I go to the homepage, which conflates setup and action; they now open withGiven I am an anonymous user(or similar state setup) before theWhenstep that navigates to the page.@javascripttag so it runs in a real browser context (Selenium/Chrome). Screenshots require a JavaScript-capable driver; without this tag the scenario was assigned to BrowserKit, which cannot take screenshots..vortex/installer/tests/Fixtures/handler_process/_baseline/tests/behat/features/to keep the scaffold in sync.Test plan
ahoy test-bddand confirm all Behat scenarios pass, including the screenshot smoke test.tests/behat/features/.