Added namespaced variables to Vortex scripts. #2267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis PR renames and namespaces many environment variables across download/upload/deploy/provision/login/task scripts and their unit tests, introducing action-scoped prefixes (e.g., VORTEX_DOWNLOAD_DB_, VORTEX_DEPLOY_LAGOON_, VORTEX_TASK_*) while retaining fallbacks to legacy names. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 15
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
scripts/vortex/deploy-lagoon.sh (1)
16-22:⚠️ Potential issue | 🟡 MinorDefault value
createis inconsistent with documented valid values.The comment documents valid values as
deploy,deploy_override_db, ordestroy, but the default fallback iscreate. While functionallycreatewill behave likedeploy(since the script only explicitly checks fordestroyanddeploy_override_db), this creates confusing documentation.Proposed fix
-VORTEX_DEPLOY_LAGOON_ACTION="${VORTEX_DEPLOY_LAGOON_ACTION:-${VORTEX_DEPLOY_ACTION:-create}}" +VORTEX_DEPLOY_LAGOON_ACTION="${VORTEX_DEPLOY_LAGOON_ACTION:-${VORTEX_DEPLOY_ACTION:-deploy}}"scripts/vortex/provision.sh (1)
38-41: 🧹 Nitpick | 🔵 TrivialConsider updating comment to reference new variable names.
The comment mentions
VORTEX_DB_DIRandVORTEX_DB_FILE, but auto-discovery now usesVORTEX_PROVISION_DB_DIRandVORTEX_PROVISION_DB_FILE. While technically accurate (due to fallback defaults), updating the comment would improve clarity.📝 Suggested comment update
# Provision database dump file. -# If not set, it will be auto-discovered from the VORTEX_DB_DIR directory using -# the VORTEX_DB_FILE name. +# If not set, it will be auto-discovered from the VORTEX_PROVISION_DB_DIR directory +# using the VORTEX_PROVISION_DB_FILE name. VORTEX_PROVISION_DB="${VORTEX_PROVISION_DB:-}"
🤖 Fix all issues with AI agents
In `@scripts/vortex/deploy-artifact.sh`:
- Around line 49-52: The changes that introduce the environment variables
VORTEX_DEPLOY_ARTIFACT_SSH_FINGERPRINT and VORTEX_DEPLOY_ARTIFACT_SSH_FILE must
not live in the original vortex scripts; instead, extract these two variable
defaulting lines into a custom wrapper under the repo's custom scripts area
(create a deploy-artifact wrapper in scripts/custom or equivalent) and have that
wrapper source or call the original deploy-artifact.sh unchanged while
exporting/overriding VORTEX_DEPLOY_ARTIFACT_SSH_FINGERPRINT and
VORTEX_DEPLOY_ARTIFACT_SSH_FILE before invocation so the original
deploy-artifact.sh remains untouched.
In `@scripts/vortex/download-db-acquia.sh`:
- Around line 28-35: The edits touch the protected vortex script variables
(VORTEX_DOWNLOAD_DB_ACQUIA_KEY, VORTEX_DOWNLOAD_DB_ACQUIA_SECRET,
VORTEX_DOWNLOAD_DB_ACQUIA_APP_NAME) inside a file under the vortex scripts tree;
move your changes to a new or existing script in scripts/custom/ that sets or
overrides these environment variables instead, or if this change must live in
the vortex file, update the repository guideline to explicitly permit this
exception and document why; ensure the final change references the same variable
names (VORTEX_DOWNLOAD_DB_ACQUIA_KEY, VORTEX_DOWNLOAD_DB_ACQUIA_SECRET,
VORTEX_DOWNLOAD_DB_ACQUIA_APP_NAME) so locating and applying the override is
straightforward.
- Around line 92-94: The error messages still reference legacy variable names;
update the fail messages and the later auth-failure message to use the current
environment variable names VORTEX_DOWNLOAD_DB_ACQUIA_KEY,
VORTEX_DOWNLOAD_DB_ACQUIA_SECRET, and VORTEX_DOWNLOAD_DB_ACQUIA_APP_NAME (the
checks around those vars and the auth failure message near the authentication
block). Locate the calls to fail that currently say "Missing value for
VORTEX_ACQUIA_*" and replace the text to mention the corresponding
VORTEX_DOWNLOAD_DB_ACQUIA_* names, and likewise update the authentication error
string at the auth block to reference the new variable names for consistency.
In `@scripts/vortex/download-db-ftp.sh`:
- Around line 30-33: The changes that define VORTEX_DOWNLOAD_DB_FTP_DB_DIR and
VORTEX_DOWNLOAD_DB_FTP_DB_FILE must not live under scripts/vortex/ per repo
guidelines; move these variable defaults into a new or existing file under
scripts/custom/ (e.g., custom variant of download-db-ftp) and leave
scripts/vortex/download-db-ftp.sh untouched. Update the custom script to export
or source the same variables (VORTEX_DOWNLOAD_DB_FTP_DB_DIR and
VORTEX_DOWNLOAD_DB_FTP_DB_FILE) so behavior is preserved, and ensure any callers
that expect these variables source the custom script instead of modifying the
original.
In `@scripts/vortex/download-db-lagoon.sh`:
- Around line 28-30: Move the customization out of the forbidden directory by
relocating the script that defines VORTEX_DOWNLOAD_DB_LAGOON_PROJECT into the
approved custom scripts area (create or update a matching download-db-lagoon.sh
under scripts/custom/) or add an explicit override there that exports
VORTEX_DOWNLOAD_DB_LAGOON_PROJECT with the same logic; ensure the original
script under the blocked directory is not modified (delete or revert it) and
update any callers to source the scripts/custom/download-db-lagoon.sh instead so
the variable resolution remains identical.
In `@scripts/vortex/download-db-s3.sh`:
- Around line 31-35: The changes introduced two variables,
VORTEX_DOWNLOAD_DB_S3_DB_DIR and VORTEX_DOWNLOAD_DB_S3_DB_FILE, inside the
protected vortex script; move these variable definitions out of the protected
script into a new or existing script under scripts/custom/ (or add them to the
project's approved customization loader) so the vortex directory is not
modified, or alternatively propose an explicit guideline exception in the repo
policy; ensure the same variable names and default semantics are preserved and
update any callers that rely on those environment variables to source the new
custom script.
In `@scripts/vortex/download-db-url.sh`:
- Around line 18-22: The change modifies variables VORTEX_DOWNLOAD_DB_URL_DB_DIR
and VORTEX_DOWNLOAD_DB_URL_DB_FILE inside scripts/vortex/download-db-url.sh
which violates the guideline to never edit scripts/vortex/; revert any edits in
that file and instead add a new script under scripts/custom/ (e.g.,
scripts/custom/download-db-url.sh) that defines those same environment variables
(VORTEX_DOWNLOAD_DB_URL_DB_DIR and VORTEX_DOWNLOAD_DB_URL_DB_FILE) and
implements the required behavior, ensuring the original
scripts/vortex/download-db-url.sh remains unchanged and any CI/README references
are updated to use the new scripts/custom version if needed.
In `@scripts/vortex/download-db.sh`:
- Around line 27-31: The changes that introduce/override VORTEX_DOWNLOAD_DB_FILE
and VORTEX_DOWNLOAD_DB_DIR must not live in the original vortex scripts; move
these environment-variable defaults into a new custom script under
scripts/custom (or your project's custom script location) and remove the
modifications from the original vortex script so the original remains untouched;
specifically, extract the lines that define VORTEX_DOWNLOAD_DB_FILE and
VORTEX_DOWNLOAD_DB_DIR (the default assignments using VORTEX_DB_FILE and
VORTEX_DB_DIR) into the new custom script and source or document that script for
users instead of modifying the original download-db script.
In `@scripts/vortex/export-db.sh`:
- Line 19: The assignment of VORTEX_EXPORT_DB_IMAGE using VORTEX_DB_IMAGE was
added under scripts/vortex
(VORTEX_EXPORT_DB_IMAGE="${VORTEX_EXPORT_DB_IMAGE:-${VORTEX_DB_IMAGE:-}}"); move
this logic into a new or existing script under scripts/custom/, e.g. add the
same variable assignment in scripts/custom/export-db.sh, and then wire that
custom script into the build/runtime flow by sourcing or invoking it from the
higher-level orchestration that previously used the vortex script so the new
variable is available where needed; ensure you remove the change from
scripts/vortex so scripts/vortex remains untouched and keep the variable names
VORTEX_EXPORT_DB_IMAGE and VORTEX_DB_IMAGE identical to preserve behavior.
In `@scripts/vortex/login-container-registry.sh`:
- Around line 53-62: The skip message references outdated variables
VORTEX_CONTAINER_REGISTRY_USER and VORTEX_CONTAINER_REGISTRY_PASS; update the
string in the note call so it uses the correct names
VORTEX_LOGIN_CONTAINER_REGISTRY_USER and VORTEX_LOGIN_CONTAINER_REGISTRY_PASS
(the conditional around them already checks VORTEX_LOGIN_CONTAINER_REGISTRY_USER
and VORTEX_LOGIN_CONTAINER_REGISTRY_PASS), ensuring the note in the else branch
matches the actual environment variable names used elsewhere in this script.
In `@scripts/vortex/task-copy-db-acquia.sh`:
- Around line 21-28: The changes were made under the protected scripts directory
(the diff defines VORTEX_TASK_COPY_DB_ACQUIA_KEY,
VORTEX_TASK_COPY_DB_ACQUIA_SECRET, VORTEX_TASK_COPY_DB_ACQUIA_APP_NAME), so move
this customization out of the protected location into the custom scripts area or
create a custom override there; specifically, transfer the contents that set
VORTEX_TASK_COPY_DB_ACQUIA_KEY / VORTEX_TASK_COPY_DB_ACQUIA_SECRET /
VORTEX_TASK_COPY_DB_ACQUIA_APP_NAME into a new script in the custom scripts
folder and ensure any callers reference the new script or source it so behavior
is unchanged, or request an explicit exception if you must keep it in the
protected directory.
In `@scripts/vortex/task-copy-files-acquia.sh`:
- Around line 21-28: The changes introducing environment vars
VORTEX_TASK_COPY_FILES_ACQUIA_KEY, VORTEX_TASK_COPY_FILES_ACQUIA_SECRET, and
VORTEX_TASK_COPY_FILES_ACQUIA_APP_NAME were made in the vortex script; move
these customizations out of the core script and into the custom overrides
location (create/modify the corresponding script named task-copy-files-acquia.sh
under the project's custom scripts area) or provide an explicit exception note;
update the core script to remove these custom env defaults and instead
source/consume the vars from the custom script, ensuring the variables
(VORTEX_TASK_COPY_FILES_ACQUIA_*) are defined only in the custom override and
not in the original vortex script.
In `@scripts/vortex/task-custom-lagoon.sh`:
- Around line 14-51: This script must not live under scripts/vortex/ per repo
policy; move the file out to scripts/custom/ (or create an overriding file
there) and update any CI/entrypoint references to point to the new location;
locate the block defining VORTEX_TASK_CUSTOM_LAGOON_* variables in the current
scripts/vortex/task-custom-lagoon.sh and copy or move it into
scripts/custom/task-custom-lagoon.sh (preserving variable names like
VORTEX_TASK_CUSTOM_LAGOON_NAME, VORTEX_TASK_CUSTOM_LAGOON_PROJECT,
VORTEX_TASK_CUSTOM_LAGOON_COMMAND, etc.), remove or revert the changes in
scripts/vortex/task-custom-lagoon.sh, and adjust any callers (CI configs,
include/import statements) to reference scripts/custom/ so the repo policy is
followed (or document an explicit exception if you cannot move it).
In `@scripts/vortex/task-purge-cache-acquia.sh`:
- Around line 21-28: This change modifies a file under scripts/vortex/ (setting
VORTEX_TASK_PURGE_CACHE_ACQUIA_KEY, VORTEX_TASK_PURGE_CACHE_ACQUIA_SECRET,
VORTEX_TASK_PURGE_CACHE_ACQUIA_APP_NAME), which violates the repo policy; move
the customization into scripts/custom/ instead (create
scripts/custom/task-purge-cache-acquia.sh or an override file) and either copy
the variable defaults there or create a small wrapper in scripts/custom/ that
sources the original vortex script and exports the same variables
(VORTEX_TASK_PURGE_CACHE_ACQUIA_KEY, VORTEX_TASK_PURGE_CACHE_ACQUIA_SECRET,
VORTEX_TASK_PURGE_CACHE_ACQUIA_APP_NAME), then remove changes from
scripts/vortex/ so the vortex/ directory remains unmodified unless an explicit
exception is approved.
In `@scripts/vortex/upload-db-s3.sh`:
- Around line 32-35: The changes that add/override VORTEX_UPLOAD_DB_S3_DB_DIR
and VORTEX_UPLOAD_DB_S3_DB_FILE must not live under scripts/vortex/; instead
create a new script under scripts/custom/ (e.g., custom-upload-db-s3.sh) that
implements the same logic and exports or sets VORTEX_UPLOAD_DB_S3_DB_DIR and
VORTEX_UPLOAD_DB_S3_DB_FILE (falling back to VORTEX_DB_DIR/VORTEX_DB_FILE) so
the original scripts/vortex/upload-db-s3.sh remains untouched; update any
callers to source or invoke the new script rather than modifying
upload-db-s3.sh.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
AlexSkrypnyk
force-pushed
the
feature/update-vars-scripts-part2
branch
from
75dbbc5 to
9697c08
Compare
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/vortex/download-db-acquia.sh (1)
104-108:⚠️ Potential issue | 🟡 MinorUpdate authentication failure message to reference new variable names.
The authentication failure message at Line 106 still references the legacy variable names. For consistency with the new naming convention, update this message as well.
✏️ Suggested fix
if echo "${token_json}" | grep -q '"error"'; then - fail "Authentication failed. Check VORTEX_ACQUIA_KEY and VORTEX_ACQUIA_SECRET. API response: ${token_json}" + fail "Authentication failed. Check VORTEX_DOWNLOAD_DB_ACQUIA_KEY and VORTEX_DOWNLOAD_DB_ACQUIA_SECRET. API response: ${token_json}" exit 1 fi
🤖 Fix all issues with AI agents
In `@scripts/vortex/download-db-container-registry.sh`:
- Line 15: The change introduces or modifies the environment variable
VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE inside an upstream script; instead
of editing that upstream script, create a new custom script under
scripts/custom/ (or a small wrapper) that exports
VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE="${VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE:-${VORTEX_DB_IMAGE:-}}"
and have callers source or invoke this custom script so the upstream
scripts/vortex/* files remain untouched; remove the modification from the
original file and ensure any CI/deployment steps are updated to source the new
custom script so the same defaulting logic for
VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE is preserved.
In `@scripts/vortex/login-container-registry.sh`:
- Around line 22-35: Your changes modify protected scripts under scripts/vortex/
(the VORTEX_LOGIN_CONTAINER_REGISTRY_* variables); move these customizations
into a new script under scripts/custom/ (e.g.,
scripts/custom/login-container-registry.sh) preserving the same variable names
and defaulting logic (VORTEX_LOGIN_CONTAINER_REGISTRY,
VORTEX_LOGIN_CONTAINER_REGISTRY_USER, VORTEX_LOGIN_CONTAINER_REGISTRY_PASS,
VORTEX_LOGIN_CONTAINER_REGISTRY_DOCKER_CONFIG) and update any callers to
source/use the new script, or alternatively leave scripts/vortex/* unchanged and
add a short documented exception in the repo docs/ or CONTRIBUTING describing
why this change must remain in scripts/vortex/ (reference the same variable
names in that exception).
In `@scripts/vortex/login.sh`:
- Line 13: The assignment to VORTEX_LOGIN_UNBLOCK_ADMIN in
scripts/vortex/login.sh must not be modified in-place; move this customization
into a new script under scripts/custom/ (e.g., scripts/custom/login.sh) or
create a wrapper that sets
VORTEX_LOGIN_UNBLOCK_ADMIN="${VORTEX_LOGIN_UNBLOCK_ADMIN:-${VORTEX_UNBLOCK_ADMIN:-1}}"
before invoking the original scripts/vortex/login.sh, or alternatively add a
documented exception in the repo policy docs; locate the variable line
(VORTEX_LOGIN_UNBLOCK_ADMIN) in the diff and either relocate the change to
scripts/custom/ or supply the formal exception documentation as required.
In `@scripts/vortex/logout.sh`:
- Around line 12-13: Move the environment-variable change out of the tracked
vortex script and into a custom script: create a new executable script under the
custom scripts area that exports the same variable
VORTEX_LOGOUT_BLOCK_ADMIN="${VORTEX_LOGOUT_BLOCK_ADMIN:-${VORTEX_UNBLOCK_ADMIN:-1}}"
(or sources it) and keep the original logout script untouched; ensure the new
custom script is loaded where needed (or documented to be sourced) and has
appropriate permissions so behavior is preserved without modifying the original
scripts.
In `@scripts/vortex/provision.sh`:
- Around line 58-65: Revert the edits to the provision script and instead place
the variable overrides into a custom script or override hook so the original
scripts/vortex provision script remains untouched; specifically, move the
assignments for VORTEX_PROVISION_DB_DIR, VORTEX_PROVISION_DB_FILE, and
VORTEX_PROVISION_DB_IMAGE into a new script under your custom hooks (or a
scripts/custom provision wrapper) that exports the same variables before
invoking the original provisioning flow, ensuring the original function/behavior
in the provision script is not modified.
|
|
||
| # The container image containing database passed in a form of `<org>/<repository>`. | ||
| VORTEX_DB_IMAGE="${VORTEX_DB_IMAGE:-}" | ||
| VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE="${VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE:-${VORTEX_DB_IMAGE:-}}" |
There was a problem hiding this comment.
Changes must live under scripts/custom/, not scripts/vortex/.
Repository rules forbid modifying scripts/vortex/; relocate these updates to scripts/custom/ (or a custom wrapper) and keep the upstream script untouched.
As per coding guidelines: “Never modify scripts/vortex/ - use scripts/custom/ for custom scripts”.
🤖 Prompt for AI Agents
In `@scripts/vortex/download-db-container-registry.sh` at line 15, The change
introduces or modifies the environment variable
VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE inside an upstream script; instead
of editing that upstream script, create a new custom script under
scripts/custom/ (or a small wrapper) that exports
VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE="${VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE:-${VORTEX_DB_IMAGE:-}}"
and have callers source or invoke this custom script so the upstream
scripts/vortex/* files remain untouched; remove the modification from the
original file and ensure any CI/deployment steps are updated to source the new
custom script so the same defaulting logic for
VORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE is preserved.
Comment on lines
+22
to
+35
| VORTEX_LOGIN_CONTAINER_REGISTRY="${VORTEX_LOGIN_CONTAINER_REGISTRY:-${VORTEX_CONTAINER_REGISTRY:-docker.io}}" | ||
|
|
||
| # The username to login into the container registry. | ||
| # | ||
| # If not provided, the script will skip the login step. | ||
| VORTEX_CONTAINER_REGISTRY_USER="${VORTEX_CONTAINER_REGISTRY_USER:-}" | ||
| VORTEX_LOGIN_CONTAINER_REGISTRY_USER="${VORTEX_LOGIN_CONTAINER_REGISTRY_USER:-${VORTEX_CONTAINER_REGISTRY_USER:-}}" | ||
|
|
||
| # The password to login into the container registry. | ||
| # | ||
| # If not provided, the script will skip the login step. | ||
| VORTEX_CONTAINER_REGISTRY_PASS="${VORTEX_CONTAINER_REGISTRY_PASS:-}" | ||
| VORTEX_LOGIN_CONTAINER_REGISTRY_PASS="${VORTEX_LOGIN_CONTAINER_REGISTRY_PASS:-${VORTEX_CONTAINER_REGISTRY_PASS:-}}" | ||
|
|
||
| # Path to Docker configuration directory. | ||
| DOCKER_CONFIG="${DOCKER_CONFIG:-${HOME}/.docker}" | ||
| VORTEX_LOGIN_CONTAINER_REGISTRY_DOCKER_CONFIG="${VORTEX_LOGIN_CONTAINER_REGISTRY_DOCKER_CONFIG:-${DOCKER_CONFIG:-${HOME}/.docker}}" |
There was a problem hiding this comment.
Move changes out of scripts/vortex/ per repo policy.
This script is in the protected directory; please relocate customizations to scripts/custom/ or document an explicit exception.
As per coding guidelines "scripts/**/*.{sh,php,js}: Never modify scripts/vortex/ - use scripts/custom/ for custom scripts".
Also applies to: 53-59
🤖 Prompt for AI Agents
In `@scripts/vortex/login-container-registry.sh` around lines 22 - 35, Your
changes modify protected scripts under scripts/vortex/ (the
VORTEX_LOGIN_CONTAINER_REGISTRY_* variables); move these customizations into a
new script under scripts/custom/ (e.g.,
scripts/custom/login-container-registry.sh) preserving the same variable names
and defaulting logic (VORTEX_LOGIN_CONTAINER_REGISTRY,
VORTEX_LOGIN_CONTAINER_REGISTRY_USER, VORTEX_LOGIN_CONTAINER_REGISTRY_PASS,
VORTEX_LOGIN_CONTAINER_REGISTRY_DOCKER_CONFIG) and update any callers to
source/use the new script, or alternatively leave scripts/vortex/* unchanged and
add a short documented exception in the repo docs/ or CONTRIBUTING describing
why this change must remain in scripts/vortex/ (reference the same variable
names in that exception).
|
|
||
| # Flag to unblock admin. | ||
| VORTEX_UNBLOCK_ADMIN="${VORTEX_UNBLOCK_ADMIN:-1}" | ||
| VORTEX_LOGIN_UNBLOCK_ADMIN="${VORTEX_LOGIN_UNBLOCK_ADMIN:-${VORTEX_UNBLOCK_ADMIN:-1}}" |
There was a problem hiding this comment.
Move changes out of scripts/vortex/ per repo policy.
This script is in the protected directory; please relocate customizations to scripts/custom/ or document an explicit exception.
As per coding guidelines "scripts/**/*.{sh,php,js}: Never modify scripts/vortex/ - use scripts/custom/ for custom scripts".
Also applies to: 27-27
🤖 Prompt for AI Agents
In `@scripts/vortex/login.sh` at line 13, The assignment to
VORTEX_LOGIN_UNBLOCK_ADMIN in scripts/vortex/login.sh must not be modified
in-place; move this customization into a new script under scripts/custom/ (e.g.,
scripts/custom/login.sh) or create a wrapper that sets
VORTEX_LOGIN_UNBLOCK_ADMIN="${VORTEX_LOGIN_UNBLOCK_ADMIN:-${VORTEX_UNBLOCK_ADMIN:-1}}"
before invoking the original scripts/vortex/login.sh, or alternatively add a
documented exception in the repo policy docs; locate the variable line
(VORTEX_LOGIN_UNBLOCK_ADMIN) in the diff and either relocate the change to
scripts/custom/ or supply the formal exception documentation as required.
Comment on lines
12
to
+13
| # Flag to block or unblock admin. | ||
| VORTEX_UNBLOCK_ADMIN="${VORTEX_UNBLOCK_ADMIN:-1}" | ||
| VORTEX_LOGOUT_BLOCK_ADMIN="${VORTEX_LOGOUT_BLOCK_ADMIN:-${VORTEX_UNBLOCK_ADMIN:-1}}" |
There was a problem hiding this comment.
Move this change into scripts/custom/ instead of scripts/vortex/.
Repository guidelines forbid edits in scripts/vortex/; implement this in a custom script and keep the original untouched.
As per coding guidelines: “Never modify scripts/vortex/ - use scripts/custom/ for custom scripts”.
Also applies to: 27-27
🤖 Prompt for AI Agents
In `@scripts/vortex/logout.sh` around lines 12 - 13, Move the environment-variable
change out of the tracked vortex script and into a custom script: create a new
executable script under the custom scripts area that exports the same variable
VORTEX_LOGOUT_BLOCK_ADMIN="${VORTEX_LOGOUT_BLOCK_ADMIN:-${VORTEX_UNBLOCK_ADMIN:-1}}"
(or sources it) and keep the original logout script untouched; ensure the new
custom script is loaded where needed (or documented to be sourced) and has
appropriate permissions so behavior is preserved without modifying the original
scripts.
Comment on lines
58
to
+65
| # Directory with database dump file. | ||
| VORTEX_DB_DIR="${VORTEX_DB_DIR:-./.data}" | ||
| VORTEX_PROVISION_DB_DIR="${VORTEX_PROVISION_DB_DIR:-${VORTEX_DB_DIR:-./.data}}" | ||
|
|
||
| # Database dump file name. | ||
| VORTEX_DB_FILE="${VORTEX_DB_FILE:-db.sql}" | ||
| VORTEX_PROVISION_DB_FILE="${VORTEX_PROVISION_DB_FILE:-${VORTEX_DB_FILE:-db.sql}}" | ||
|
|
||
| # Name of the pre-built database container image. | ||
| VORTEX_DB_IMAGE="${VORTEX_DB_IMAGE:-}" | ||
| VORTEX_PROVISION_DB_IMAGE="${VORTEX_PROVISION_DB_IMAGE:-${VORTEX_DB_IMAGE:-}}" |
There was a problem hiding this comment.
Policy violation: scripts/vortex/ must remain unmodified.
These changes are inside scripts/vortex/provision.sh, but the guidelines prohibit modifying any scripts/vortex/ files. Move the changes to scripts/custom/ (or implement via an override hook) instead of editing this file directly.
As per coding guidelines, "scripts/**/*.{sh,php,js}: Never modify scripts/vortex/ - use scripts/custom/ for custom scripts".
🤖 Prompt for AI Agents
In `@scripts/vortex/provision.sh` around lines 58 - 65, Revert the edits to the
provision script and instead place the variable overrides into a custom script
or override hook so the original scripts/vortex provision script remains
untouched; specifically, move the assignments for VORTEX_PROVISION_DB_DIR,
VORTEX_PROVISION_DB_FILE, and VORTEX_PROVISION_DB_IMAGE into a new script under
your custom hooks (or a scripts/custom provision wrapper) that exports the same
variables before invoking the original provisioning flow, ensuring the original
function/behavior in the provision script is not modified.
Member
Author
|
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Member
Author
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2267 +/- ##
==========================================
- Coverage 84.19% 76.46% -7.73%
==========================================
Files 75 107 +32
Lines 3751 5834 +2083
Branches 44 0 -44
==========================================
+ Hits 3158 4461 +1303
- Misses 593 1373 +780 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlexSkrypnyk
force-pushed
the
feature/update-vars-scripts-part2
branch
from
9697c08 to
39500ec
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In @.vortex/tests/composer.json:
- Around line 30-33: The composer.json entry for ergebnis/composer-normalize
currently pins a non-existent version "^2.50.0"; update the dependency string
for "ergebnis/composer-normalize" from "^2.50.0" to "^2.49.0" so composer
install succeeds (leave the other dependencies phpstan/phpstan, phpunit/phpunit,
and rector/rector unchanged).
In `@scripts/vortex/download-db-lagoon.sh`:
- Line 29: Update the parameter expansion for VORTEX_DOWNLOAD_DB_LAGOON_PROJECT
so the missing-variable error mentions the new primary name as well as the
legacy one: change the default/error text in the expansion of
VORTEX_DOWNLOAD_DB_LAGOON_PROJECT (currently using LAGOON_PROJECT in the
message) to include both "VORTEX_DOWNLOAD_DB_LAGOON_PROJECT" and
"LAGOON_PROJECT" (e.g., "Missing required environment variable
VORTEX_DOWNLOAD_DB_LAGOON_PROJECT or LAGOON_PROJECT.") so anyone seeing the
error knows which new and old vars are relevant.
In `@scripts/vortex/task-custom-lagoon.sh`:
- Around line 14-51: The new namespaced env vars (VORTEX_TASK_CUSTOM_LAGOON_*)
currently do not fall back to the legacy VORTEX_TASK_LAGOON_* names, breaking
backward compatibility; update each default assignment to include the legacy
counterpart as a secondary fallback (e.g., for VORTEX_TASK_CUSTOM_LAGOON_PROJECT
use
${VORTEX_TASK_CUSTOM_LAGOON_PROJECT:-${VORTEX_TASK_LAGOON_PROJECT:-${LAGOON_PROJECT:-}}}),
and likewise chain fallbacks for VORTEX_TASK_CUSTOM_LAGOON_BRANCH,
VORTEX_TASK_CUSTOM_LAGOON_COMMAND, VORTEX_TASK_CUSTOM_LAGOON_INSTANCE,
VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_GRAPHQL,
VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_HOSTNAME,
VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_PORT,
VORTEX_TASK_CUSTOM_LAGOON_SSH_FINGERPRINT, VORTEX_TASK_CUSTOM_LAGOON_SSH_FILE,
VORTEX_TASK_CUSTOM_LAGOON_CLI_PATH, VORTEX_TASK_CUSTOM_LAGOON_CLI_FORCE_INSTALL,
and VORTEX_TASK_CUSTOM_LAGOON_CLI_VERSION so that each tries the legacy
VORTEX_TASK_LAGOON_* name before the current defaults.
Comment on lines
+30
to
+33
| "ergebnis/composer-normalize": "^2.50.0", | ||
| "phpstan/phpstan": "^2.1.38", | ||
| "phpunit/phpunit": "^12.5.10", | ||
| "rector/rector": "^2.3.6", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
ergebnis/composer-normalize 2.50.0 release notes changelog
💡 Result:
Eine Version 2.50.0 von ergebnis/composer-normalize scheint derzeit nicht veröffentlicht zu sein. Auf Packagist ist als aktuellste veröffentlichte Version 2.49.0 (2026-01-26) gelistet. [1]
Auch der SourceForge-Mirror zeigt nur Releases bis 2.48.2 (2025-09-06). [2]
Wenn du dennoch „Release Notes/Changelog“ zu 2.50.0 suchst, ist es sehr wahrscheinlich, dass es (noch) keinen Release-Tag dafür gibt – dann wäre höchstens der unreleased Stand im Repository relevant. [1]
Quellen: [1] [2]
🌐 Web query:
phpstan/phpstan 2.1.38 release notes breaking changes PHP 8.3
💡 Result:
PHPStan 2.1.38 (released 2026-01-30) is a patch release and its published notes do not list any breaking changes, including anything specific to PHP 8.3. Per PHPStan’s own backward-compatibility promise, patch releases are not where BC breaks are expected. [1] [2]
2.1.38 release notes (highlights):
- Performance: “another 5–10% faster”
- Changes: removes the PHP version constraint from the
#[\Override]attribute rules; tweaksOverridingPropertyRuledefaulting behavior (only on PHP 8.5+); several inference improvements - Bugfix: “Fixed escaped hash in regex extended mode” [1]
PHP 8.3 note: there’s no PHP 8.3 breaking-change mention in 2.1.38’s notes. If you’re chasing a PHP 8.3-specific fix in the 2.1 line, one explicitly called out earlier is 2.1.28: “Fix PHP 8.3 polyfill”. [3]
Sources: [1] [2] [3]
🌐 Web query:
phpunit/phpunit 12.5.10 release notes breaking changes
💡 Result:
PHPUnit 12.5.10 (released Feb 8, 2026) — release notes / breaking changes
What changed
- Fixed: #6495 — “Source map for issue trigger identification is regenerated in process isolation child processes.” [1]
Breaking changes
- None documented for 12.5.10 (it’s a patch release, and the 12.5 line is announced as backward compatible with the previous version). [2]
If you’re upgrading across major versions
If you are coming from PHPUnit 11 or older, the breaking changes are in PHPUnit 12 itself (major release), e.g. PHP 8.3+ requirement and various removals/cleanups (including moving from annotations to attributes in some areas). [3]
Sources: [1] [2] [3]
🌐 Web query:
rector/rector 2.3.6 release notes changelog
💡 Result:
rector/rector (rectorphp/rector) v2.3.6 — release notes / changelog
Release date: 2026-02-06. [1]
New Features
- Allow using a canonical
rector.dist.phpdist file (#7845). [1][2]
Bugfixes
- [Php83] Handle parent class consume trait in
AddOverrideAttributeToOverriddenMethodsRector(#7868). [1][2] - Fix fixture source warning in
AddOverrideAttributeToOverriddenMethodsRector(missing TestCase suffix) (#7869). [1][2] - Add
JSON_THROW_ON_ERROReven if there is already a flag (#7867). [1][2] - [DeadCode] No need extra parentheses on multiply-to-function-call case (
#7883). [1][2] - [Php80] Fix crash on empty name attribute field value in
AnnotationToAttributeRector(#7864). [1][2] - Fix
JsonValidateRector: remove associative argument not supported byjson_validate(#7865). [1][2] - Fix deep
ArrayItemscope filling onForeach_value (#7873). [1] - Fix
StaticCallOnNonStaticToInstanceCallRectorfor same-class calls (#7876). [1] - Bump PHPStan to 2.1.38 (
#7879). [1] - [DeadCode] Allow removing
@varon expression assign inRemoveUselessVarTagRector(#7871). [1] - [DeadCode] Handle multiply-to-parenthesized in
RemoveDeadZeroAndOneOperationRector(#7882). [1]
rectorphp/rector-symfony
- Update set usage in readme (
#919). [1]
rectorphp/rector-phpunit (highlights)
- [phpunit 12] Add
CreateStubInCoalesceArgRector(#650). [1] - Add multiple code-quality and phpunit-12 related rectors/fixes (
#649–[#618] Added suppressing of FORCE_DB_DOWNLOAD flag locally + init of .env.local. #621 range shown in notes). [1]
Sources: GitHub release notes + mirrored release summary. [1][2]
Critical: ergebnis/composer-normalize version 2.50.0 does not exist.
As of 2026-02-06, the latest published version of ergebnis/composer-normalize is 2.49.0 (2026-01-26). The specified version ^2.50.0 will cause composer install to fail. Downgrade to ^2.49.0.
The other three packages are compatible: phpstan/phpstan 2.1.38, phpunit/phpunit 12.5.10, and rector/rector 2.3.6 are all recent patch/stable releases with no breaking changes and full PHP 8.3+ support.
🤖 Prompt for AI Agents
In @.vortex/tests/composer.json around lines 30 - 33, The composer.json entry
for ergebnis/composer-normalize currently pins a non-existent version "^2.50.0";
update the dependency string for "ergebnis/composer-normalize" from "^2.50.0" to
"^2.49.0" so composer install succeeds (leave the other dependencies
phpstan/phpstan, phpunit/phpunit, and rector/rector unchanged).
|
|
||
| # Lagoon project name. | ||
| LAGOON_PROJECT="${LAGOON_PROJECT:?Missing required environment variable LAGOON_PROJECT.}" | ||
| VORTEX_DOWNLOAD_DB_LAGOON_PROJECT="${VORTEX_DOWNLOAD_DB_LAGOON_PROJECT:-${LAGOON_PROJECT:?Missing required environment variable LAGOON_PROJECT.}}" |
There was a problem hiding this comment.
Clarify missing-project error message to include the new var.
If both vars are unset, the current message only mentions LAGOON_PROJECT, which is confusing now that VORTEX_DOWNLOAD_DB_LAGOON_PROJECT is the primary name.
💡 Suggested change
-VORTEX_DOWNLOAD_DB_LAGOON_PROJECT="${VORTEX_DOWNLOAD_DB_LAGOON_PROJECT:-${LAGOON_PROJECT:?Missing required environment variable LAGOON_PROJECT.}}"
+VORTEX_DOWNLOAD_DB_LAGOON_PROJECT="${VORTEX_DOWNLOAD_DB_LAGOON_PROJECT:-${LAGOON_PROJECT:?Missing value for VORTEX_DOWNLOAD_DB_LAGOON_PROJECT or LAGOON_PROJECT.}}"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| VORTEX_DOWNLOAD_DB_LAGOON_PROJECT="${VORTEX_DOWNLOAD_DB_LAGOON_PROJECT:-${LAGOON_PROJECT:?Missing required environment variable LAGOON_PROJECT.}}" | |
| VORTEX_DOWNLOAD_DB_LAGOON_PROJECT="${VORTEX_DOWNLOAD_DB_LAGOON_PROJECT:-${LAGOON_PROJECT:?Missing value for VORTEX_DOWNLOAD_DB_LAGOON_PROJECT or LAGOON_PROJECT.}}" |
🤖 Prompt for AI Agents
In `@scripts/vortex/download-db-lagoon.sh` at line 29, Update the parameter
expansion for VORTEX_DOWNLOAD_DB_LAGOON_PROJECT so the missing-variable error
mentions the new primary name as well as the legacy one: change the
default/error text in the expansion of VORTEX_DOWNLOAD_DB_LAGOON_PROJECT
(currently using LAGOON_PROJECT in the message) to include both
"VORTEX_DOWNLOAD_DB_LAGOON_PROJECT" and "LAGOON_PROJECT" (e.g., "Missing
required environment variable VORTEX_DOWNLOAD_DB_LAGOON_PROJECT or
LAGOON_PROJECT.") so anyone seeing the error knows which new and old vars are
relevant.
Comment on lines
14
to
+51
| # The task name. | ||
| VORTEX_TASK_LAGOON_NAME="${VORTEX_TASK_LAGOON_NAME:-Automation task}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_NAME="${VORTEX_TASK_CUSTOM_LAGOON_NAME:-Automation task}" | ||
|
|
||
| # The Lagoon project to run tasks for. | ||
| VORTEX_TASK_LAGOON_PROJECT="${VORTEX_TASK_LAGOON_PROJECT:-${LAGOON_PROJECT:-}}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_PROJECT="${VORTEX_TASK_CUSTOM_LAGOON_PROJECT:-${LAGOON_PROJECT:-}}" | ||
|
|
||
| # The Lagoon branch to run the task on. | ||
| VORTEX_TASK_LAGOON_BRANCH="${VORTEX_TASK_LAGOON_BRANCH:-}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_BRANCH="${VORTEX_TASK_CUSTOM_LAGOON_BRANCH:-}" | ||
|
|
||
| # The task command to execute. | ||
| VORTEX_TASK_LAGOON_COMMAND="${VORTEX_TASK_LAGOON_COMMAND:-}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_COMMAND="${VORTEX_TASK_CUSTOM_LAGOON_COMMAND:-}" | ||
|
|
||
| # The Lagoon instance name to interact with. | ||
| VORTEX_TASK_LAGOON_INSTANCE="${VORTEX_TASK_LAGOON_INSTANCE:-amazeeio}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_INSTANCE="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE:-amazeeio}" | ||
|
|
||
| # The Lagoon instance GraphQL endpoint to interact with. | ||
| VORTEX_TASK_LAGOON_INSTANCE_GRAPHQL="${VORTEX_TASK_LAGOON_INSTANCE_GRAPHQL:-https://api.lagoon.amazeeio.cloud/graphql}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_GRAPHQL="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_GRAPHQL:-https://api.lagoon.amazeeio.cloud/graphql}" | ||
|
|
||
| # The Lagoon instance hostname to interact with. | ||
| VORTEX_TASK_LAGOON_INSTANCE_HOSTNAME="${VORTEX_TASK_LAGOON_INSTANCE_HOSTNAME:-ssh.lagoon.amazeeio.cloud}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_HOSTNAME="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_HOSTNAME:-ssh.lagoon.amazeeio.cloud}" | ||
|
|
||
| # The Lagoon instance port to interact with. | ||
| VORTEX_TASK_LAGOON_INSTANCE_PORT="${VORTEX_TASK_LAGOON_INSTANCE_PORT:-32222}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_PORT="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_PORT:-32222}" | ||
|
|
||
| # SSH key fingerprint used to connect to a remote. | ||
| VORTEX_TASK_SSH_FINGERPRINT="${VORTEX_TASK_SSH_FINGERPRINT:-}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_SSH_FINGERPRINT="${VORTEX_TASK_CUSTOM_LAGOON_SSH_FINGERPRINT:-}" | ||
|
|
||
| # Default SSH file used if custom fingerprint is not provided. | ||
| VORTEX_TASK_SSH_FILE="${VORTEX_TASK_SSH_FILE:-${HOME}/.ssh/id_rsa}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_SSH_FILE="${VORTEX_TASK_CUSTOM_LAGOON_SSH_FILE:-${HOME}/.ssh/id_rsa}" | ||
|
|
||
| # Location of the Lagoon CLI binary. | ||
| VORTEX_LAGOONCLI_PATH="${VORTEX_LAGOONCLI_PATH:-/tmp}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_CLI_PATH="${VORTEX_TASK_CUSTOM_LAGOON_CLI_PATH:-/tmp}" | ||
|
|
||
| # Flag to force the installation of Lagoon CLI. | ||
| VORTEX_LAGOONCLI_FORCE_INSTALL="${VORTEX_LAGOONCLI_FORCE_INSTALL:-}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_CLI_FORCE_INSTALL="${VORTEX_TASK_CUSTOM_LAGOON_CLI_FORCE_INSTALL:-}" | ||
|
|
||
| # Lagoon CLI version to use. | ||
| VORTEX_LAGOONCLI_VERSION="${VORTEX_LAGOONCLI_VERSION:-v0.32.0}" | ||
| VORTEX_TASK_CUSTOM_LAGOON_CLI_VERSION="${VORTEX_TASK_CUSTOM_LAGOON_CLI_VERSION:-v0.32.0}" |
There was a problem hiding this comment.
Add legacy VORTEX_TASK_LAGOON_ fallbacks to preserve backward compatibility.*
The new variables only read the namespaced values, so legacy env vars (VORTEX_TASK_LAGOON_*) are ignored; downstream required-value checks then fail or use defaults unexpectedly. This breaks the stated compatibility contract.
🔧 Proposed fix (fallback chain to legacy names)
-VORTEX_TASK_CUSTOM_LAGOON_NAME="${VORTEX_TASK_CUSTOM_LAGOON_NAME:-Automation task}"
+VORTEX_TASK_CUSTOM_LAGOON_NAME="${VORTEX_TASK_CUSTOM_LAGOON_NAME:-${VORTEX_TASK_LAGOON_NAME:-Automation task}}"
-VORTEX_TASK_CUSTOM_LAGOON_PROJECT="${VORTEX_TASK_CUSTOM_LAGOON_PROJECT:-${LAGOON_PROJECT:-}}"
+VORTEX_TASK_CUSTOM_LAGOON_PROJECT="${VORTEX_TASK_CUSTOM_LAGOON_PROJECT:-${VORTEX_TASK_LAGOON_PROJECT:-${LAGOON_PROJECT:-}}}"
-VORTEX_TASK_CUSTOM_LAGOON_BRANCH="${VORTEX_TASK_CUSTOM_LAGOON_BRANCH:-}"
+VORTEX_TASK_CUSTOM_LAGOON_BRANCH="${VORTEX_TASK_CUSTOM_LAGOON_BRANCH:-${VORTEX_TASK_LAGOON_BRANCH:-}}"
-VORTEX_TASK_CUSTOM_LAGOON_COMMAND="${VORTEX_TASK_CUSTOM_LAGOON_COMMAND:-}"
+VORTEX_TASK_CUSTOM_LAGOON_COMMAND="${VORTEX_TASK_CUSTOM_LAGOON_COMMAND:-${VORTEX_TASK_LAGOON_COMMAND:-}}"
-VORTEX_TASK_CUSTOM_LAGOON_INSTANCE="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE:-amazeeio}"
+VORTEX_TASK_CUSTOM_LAGOON_INSTANCE="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE:-${VORTEX_TASK_LAGOON_INSTANCE:-amazeeio}}"
-VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_GRAPHQL="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_GRAPHQL:-https://api.lagoon.amazeeio.cloud/graphql}"
+VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_GRAPHQL="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_GRAPHQL:-${VORTEX_TASK_LAGOON_INSTANCE_GRAPHQL:-https://api.lagoon.amazeeio.cloud/graphql}}"
-VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_HOSTNAME="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_HOSTNAME:-ssh.lagoon.amazeeio.cloud}"
+VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_HOSTNAME="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_HOSTNAME:-${VORTEX_TASK_LAGOON_INSTANCE_HOSTNAME:-ssh.lagoon.amazeeio.cloud}}"
-VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_PORT="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_PORT:-32222}"
+VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_PORT="${VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_PORT:-${VORTEX_TASK_LAGOON_INSTANCE_PORT:-32222}}"
-VORTEX_TASK_CUSTOM_LAGOON_SSH_FINGERPRINT="${VORTEX_TASK_CUSTOM_LAGOON_SSH_FINGERPRINT:-}"
+VORTEX_TASK_CUSTOM_LAGOON_SSH_FINGERPRINT="${VORTEX_TASK_CUSTOM_LAGOON_SSH_FINGERPRINT:-${VORTEX_TASK_LAGOON_SSH_FINGERPRINT:-}}"
-VORTEX_TASK_CUSTOM_LAGOON_SSH_FILE="${VORTEX_TASK_CUSTOM_LAGOON_SSH_FILE:-${HOME}/.ssh/id_rsa}"
+VORTEX_TASK_CUSTOM_LAGOON_SSH_FILE="${VORTEX_TASK_CUSTOM_LAGOON_SSH_FILE:-${VORTEX_TASK_LAGOON_SSH_FILE:-${HOME}/.ssh/id_rsa}}"
-VORTEX_TASK_CUSTOM_LAGOON_CLI_PATH="${VORTEX_TASK_CUSTOM_LAGOON_CLI_PATH:-/tmp}"
+VORTEX_TASK_CUSTOM_LAGOON_CLI_PATH="${VORTEX_TASK_CUSTOM_LAGOON_CLI_PATH:-${VORTEX_TASK_LAGOON_CLI_PATH:-/tmp}}"
-VORTEX_TASK_CUSTOM_LAGOON_CLI_FORCE_INSTALL="${VORTEX_TASK_CUSTOM_LAGOON_CLI_FORCE_INSTALL:-}"
+VORTEX_TASK_CUSTOM_LAGOON_CLI_FORCE_INSTALL="${VORTEX_TASK_CUSTOM_LAGOON_CLI_FORCE_INSTALL:-${VORTEX_TASK_LAGOON_CLI_FORCE_INSTALL:-}}"
-VORTEX_TASK_CUSTOM_LAGOON_CLI_VERSION="${VORTEX_TASK_CUSTOM_LAGOON_CLI_VERSION:-v0.32.0}"
+VORTEX_TASK_CUSTOM_LAGOON_CLI_VERSION="${VORTEX_TASK_CUSTOM_LAGOON_CLI_VERSION:-${VORTEX_TASK_LAGOON_CLI_VERSION:-v0.32.0}}"🤖 Prompt for AI Agents
In `@scripts/vortex/task-custom-lagoon.sh` around lines 14 - 51, The new
namespaced env vars (VORTEX_TASK_CUSTOM_LAGOON_*) currently do not fall back to
the legacy VORTEX_TASK_LAGOON_* names, breaking backward compatibility; update
each default assignment to include the legacy counterpart as a secondary
fallback (e.g., for VORTEX_TASK_CUSTOM_LAGOON_PROJECT use
${VORTEX_TASK_CUSTOM_LAGOON_PROJECT:-${VORTEX_TASK_LAGOON_PROJECT:-${LAGOON_PROJECT:-}}}),
and likewise chain fallbacks for VORTEX_TASK_CUSTOM_LAGOON_BRANCH,
VORTEX_TASK_CUSTOM_LAGOON_COMMAND, VORTEX_TASK_CUSTOM_LAGOON_INSTANCE,
VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_GRAPHQL,
VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_HOSTNAME,
VORTEX_TASK_CUSTOM_LAGOON_INSTANCE_PORT,
VORTEX_TASK_CUSTOM_LAGOON_SSH_FINGERPRINT, VORTEX_TASK_CUSTOM_LAGOON_SSH_FILE,
VORTEX_TASK_CUSTOM_LAGOON_CLI_PATH, VORTEX_TASK_CUSTOM_LAGOON_CLI_FORCE_INSTALL,
and VORTEX_TASK_CUSTOM_LAGOON_CLI_VERSION so that each tries the legacy
VORTEX_TASK_LAGOON_* name before the current defaults.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Member
Author
|
Member
Author
|
AlexSkrypnyk
force-pushed
the
feature/update-vars-scripts-part2
branch
from
39500ec to
2a3a874
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.vortex/tests/composer.json:
- Line 26: The composer dependency "alexskrypnyk/shellvar" is pinned to "^1.5"
which doesn't exist on Packagist; update the constraint in composer.json to a
published release (e.g., "1.2.0" or "^1.2") or change it to a valid existing
tag, ensuring the composer require line referencing alexskrypnyk/shellvar is
replaced with the corrected version constraint and then run composer update to
verify resolution.
| "alexskrypnyk/file": "^0.19.0", | ||
| "alexskrypnyk/phpunit-helpers": "^0.15", | ||
| "alexskrypnyk/shellvar": "^1.4.0", | ||
| "alexskrypnyk/shellvar": "^1.5", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
alexskrypnyk/shellvar packagist versions
💡 Result:
Packagist versions for alexskrypnyk/shellvar (newest → oldest):
1.2.0(2025-01-10)1.1.01.0.00.7.00.6.10.6.00.5.00.4.00.3.00.2.00.1.0- Dev branches:
dev-main,dev-renovate/phpunit-phpunit-12.x[1]
Pin alexskrypnyk/shellvar to a published version.
Packagist currently lists releases only up to 1.2.0 (no 1.5.x), so ^1.5 won't resolve and will break installs/CI. Either publish 1.5.0 or downgrade the constraint to the latest available release.
🛠️ Suggested fix
- "alexskrypnyk/shellvar": "^1.5",
+ "alexskrypnyk/shellvar": "^1.2.0",🤖 Prompt for AI Agents
In @.vortex/tests/composer.json at line 26, The composer dependency
"alexskrypnyk/shellvar" is pinned to "^1.5" which doesn't exist on Packagist;
update the constraint in composer.json to a published release (e.g., "1.2.0" or
"^1.2") or change it to a valid existing tag, ensuring the composer require line
referencing alexskrypnyk/shellvar is replaced with the corrected version
constraint and then run composer update to verify resolution.
|
Member
Author
|
Member
Author
|
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Namespace variable remapping in
scripts/vortex/Summary
Each script's body now references only variables in its own namespace.
Upstream/shared variables are remapped at the top of each script using the
fallback pattern, preserving backward compatibility.
Global variables
WEBROOTandDRUPAL_*are intentionally kept as-is — theyare not script-specific and remain global.
Variable renames
download-db.shdownload-db.shVORTEX_DOWNLOAD_DB_FILEVORTEX_DB_FILEdownload-db.shVORTEX_DOWNLOAD_DB_DIRVORTEX_DB_DIRdownload-db-acquia.shdownload-db-acquia.shVORTEX_DOWNLOAD_DB_ACQUIA_KEYVORTEX_ACQUIA_KEYdownload-db-acquia.shVORTEX_DOWNLOAD_DB_ACQUIA_SECRETVORTEX_ACQUIA_SECRETdownload-db-acquia.shVORTEX_DOWNLOAD_DB_ACQUIA_APP_NAMEVORTEX_ACQUIA_APP_NAMEdownload-db-acquia.shVORTEX_DOWNLOAD_DB_ACQUIA_DB_DIRVORTEX_DB_DIRdownload-db-acquia.shVORTEX_DOWNLOAD_DB_ACQUIA_DB_FILEVORTEX_DB_FILEdownload-db-container-registry.shdownload-db-container-registry.shVORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGEVORTEX_DB_IMAGEdownload-db-container-registry.shVORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_DB_DIRVORTEX_DB_DIRdownload-db-container-registry.shVORTEX_DOWNLOAD_DB_CONTAINER_REGISTRY_IMAGE_BASEVORTEX_DB_IMAGE_BASEdownload-db-ftp.shdownload-db-ftp.shVORTEX_DOWNLOAD_DB_FTP_DB_DIRVORTEX_DB_DIRdownload-db-ftp.shVORTEX_DOWNLOAD_DB_FTP_DB_FILEVORTEX_DB_FILEdownload-db-lagoon.shdownload-db-lagoon.shVORTEX_DOWNLOAD_DB_LAGOON_PROJECTLAGOON_PROJECTdownload-db-lagoon.shVORTEX_DOWNLOAD_DB_LAGOON_DB_DIRVORTEX_DB_DIRdownload-db-lagoon.shVORTEX_DOWNLOAD_DB_LAGOON_DB_FILEVORTEX_DB_FILEdownload-db-s3.shdownload-db-s3.shVORTEX_DOWNLOAD_DB_S3_DB_DIRVORTEX_DB_DIRdownload-db-s3.shVORTEX_DOWNLOAD_DB_S3_DB_FILEVORTEX_DB_FILEdownload-db-url.shdownload-db-url.shVORTEX_DOWNLOAD_DB_URL_DB_DIRVORTEX_DB_DIRdownload-db-url.shVORTEX_DOWNLOAD_DB_URL_DB_FILEVORTEX_DB_FILEdeploy-artifact.shdeploy-artifact.shVORTEX_DEPLOY_ARTIFACT_SSH_FINGERPRINTVORTEX_DEPLOY_SSH_FINGERPRINTdeploy-artifact.shVORTEX_DEPLOY_ARTIFACT_SSH_FILEVORTEX_DEPLOY_SSH_FILEdeploy-lagoon.shdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_ACTIONVORTEX_DEPLOY_ACTIONdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_PROJECTLAGOON_PROJECTdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_BRANCHVORTEX_DEPLOY_BRANCHdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_PRVORTEX_DEPLOY_PRdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_PR_HEADVORTEX_DEPLOY_PR_HEADdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_PR_BASE_BRANCHVORTEX_DEPLOY_PR_BASE_BRANCHdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_SSH_FINGERPRINTVORTEX_DEPLOY_SSH_FINGERPRINTdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_SSH_FILEVORTEX_DEPLOY_SSH_FILEdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_LAGOONCLI_PATHVORTEX_LAGOONCLI_PATHdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_LAGOONCLI_FORCE_INSTALLVORTEX_LAGOONCLI_FORCE_INSTALLdeploy-lagoon.shVORTEX_DEPLOY_LAGOON_LAGOONCLI_VERSIONVORTEX_LAGOONCLI_VERSIONexport-db.shexport-db.shVORTEX_EXPORT_DB_IMAGEVORTEX_DB_IMAGEupload-db-s3.shupload-db-s3.shVORTEX_UPLOAD_DB_S3_DB_DIRVORTEX_DB_DIRupload-db-s3.shVORTEX_UPLOAD_DB_S3_DB_FILEVORTEX_DB_FILEprovision.shprovision.shVORTEX_PROVISION_DB_DIRVORTEX_DB_DIRprovision.shVORTEX_PROVISION_DB_FILEVORTEX_DB_FILEprovision.shVORTEX_PROVISION_DB_IMAGEVORTEX_DB_IMAGElogin-container-registry.shlogin-container-registry.shVORTEX_LOGIN_CONTAINER_REGISTRYVORTEX_CONTAINER_REGISTRYlogin-container-registry.shVORTEX_LOGIN_CONTAINER_REGISTRY_USERVORTEX_CONTAINER_REGISTRY_USERlogin-container-registry.shVORTEX_LOGIN_CONTAINER_REGISTRY_PASSVORTEX_CONTAINER_REGISTRY_PASSlogin-container-registry.shVORTEX_LOGIN_CONTAINER_REGISTRY_DOCKER_CONFIGDOCKER_CONFIGlogin.shlogin.shVORTEX_LOGIN_UNBLOCK_ADMINVORTEX_UNBLOCK_ADMINlogout.shlogout.shVORTEX_LOGOUT_BLOCK_ADMINVORTEX_UNBLOCK_ADMINtask-copy-db-acquia.shtask-copy-db-acquia.shVORTEX_TASK_COPY_DB_ACQUIA_KEYVORTEX_ACQUIA_KEYtask-copy-db-acquia.shVORTEX_TASK_COPY_DB_ACQUIA_SECRETVORTEX_ACQUIA_SECRETtask-copy-db-acquia.shVORTEX_TASK_COPY_DB_ACQUIA_APP_NAMEVORTEX_ACQUIA_APP_NAMEtask-copy-files-acquia.shtask-copy-files-acquia.shVORTEX_TASK_COPY_FILES_ACQUIA_KEYVORTEX_ACQUIA_KEYtask-copy-files-acquia.shVORTEX_TASK_COPY_FILES_ACQUIA_SECRETVORTEX_ACQUIA_SECRETtask-copy-files-acquia.shVORTEX_TASK_COPY_FILES_ACQUIA_APP_NAMEVORTEX_ACQUIA_APP_NAMEtask-custom-lagoon.shtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_NAMEVORTEX_TASK_LAGOON_NAMEtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_PROJECTVORTEX_TASK_LAGOON_PROJECTtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_BRANCHVORTEX_TASK_LAGOON_BRANCHtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_COMMANDVORTEX_TASK_LAGOON_COMMANDtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_INSTANCEVORTEX_TASK_LAGOON_INSTANCEtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_INSTANCE_GRAPHQLVORTEX_TASK_LAGOON_INSTANCE_GRAPHQLtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_INSTANCE_HOSTNAMEVORTEX_TASK_LAGOON_INSTANCE_HOSTNAMEtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_INSTANCE_PORTVORTEX_TASK_LAGOON_INSTANCE_PORTtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_SSH_FINGERPRINTVORTEX_TASK_SSH_FINGERPRINTtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_SSH_FILEVORTEX_TASK_SSH_FILEtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_CLI_PATHVORTEX_LAGOONCLI_PATHtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_CLI_FORCE_INSTALLVORTEX_LAGOONCLI_FORCE_INSTALLtask-custom-lagoon.shVORTEX_TASK_CUSTOM_LAGOON_CLI_VERSIONVORTEX_LAGOONCLI_VERSIONtask-purge-cache-acquia.shtask-purge-cache-acquia.shVORTEX_TASK_PURGE_CACHE_ACQUIA_KEYVORTEX_ACQUIA_KEYtask-purge-cache-acquia.shVORTEX_TASK_PURGE_CACHE_ACQUIA_SECRETVORTEX_ACQUIA_SECRETtask-purge-cache-acquia.shVORTEX_TASK_PURGE_CACHE_ACQUIA_APP_NAMEVORTEX_ACQUIA_APP_NAMEVariables intentionally kept global
The following variables are not namespaced as they are global/shared:
WEBROOTDRUPAL_SITE_NAMEDRUPAL_SITE_EMAILDRUPAL_PROFILEDRUPAL_PUBLIC_FILESDRUPAL_PRIVATE_FILESDRUPAL_TEMPORARY_FILESDRUPAL_ADMIN_EMAILSummary by CodeRabbit
Breaking Changes
New Features
Chores