[#2261] Fixed Acquia settings to allow DRUPAL_CONFIG_PATH override independently of config_vcs_directory.

[AlexSkrypnyk]

Closes #2261

Summary by CodeRabbit

• Tests

  • Added test coverage for configuration path override behavior in Acquia environments.

• Refactor

  • Reorganized configuration sync directory and automatic htaccess handling for clearer, consolidated initialization while preserving existing behavior.

[coderabbitai]

Walkthrough

Adds a unit test for DRUPAL_CONFIG_PATH overriding and reorders/centralizes DRUPAL_CONFIG_PATH handling and htaccess creation in Acquia-specific settings to apply the environment variable regardless of config_vcs_directory presence.

Changes

Cohort / File(s)	Summary
Test Coverage tests/phpunit/Drupal/EnvironmentSettingsTest.php	Added testEnvironmentAcquiaConfigPathOverride() to assert DRUPAL_CONFIG_PATH overrides Acquia config_sync_directory and that related paths (config_vcs_directory fallback, environment-specific values) are set as expected.
Acquia Settings Logic web/sites/default/includes/providers/settings.acquia.php	Moved and consolidated DRUPAL_CONFIG_PATH override to a post-switch block so the env var sets config_sync_directory when present (falling back to config_vcs_directory if not) and re-enabled automatic htaccess creation in the same block.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Fixed config directory and www-redirect for non-prod in Acquia. #2012: Directly modifies settings.acquia.php to change how config_sync_directory is determined (same area of logic).
• Fixed public and private paths #1738: Updates tests and Acquia settings handling for DRUPAL_CONFIG_PATH and related config path behavior.
• Fixed false negatives assertions in settings test for testEnvironmentOverrides(). #1737: Adds/adjusts tests around DRUPAL_CONFIG_PATH-driven config_sync_directory resolution.

Suggested labels

Confirmed

Poem

🐰
A bunny hops through config lanes,
DRUPAL_CONFIG_PATH breaks old chains,
Tests hopped in to check the way,
Paths now follow what envs convey,
🎉✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: fixing Acquia settings to allow DRUPAL_CONFIG_PATH to override config_sync_directory independently of config_vcs_directory.
Linked Issues check	✅ Passed	The code changes implement the exact requirement from issue #2261: allowing DRUPAL_CONFIG_PATH to override config_sync_directory regardless of whether config_vcs_directory is set, with proper fallback logic.
Out of Scope Changes check	✅ Passed	All changes are directly related to the linked issue objective. The test addition validates the new behavior, and the settings file modification implements the required override logic without unrelated alterations.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/2261-acquia-config-path

---

No actionable comments were generated in the recent review. 🎉

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@tests/phpunit/Drupal/EnvironmentSettingsTest.php`:
- Around line 781-785: Add a new unit test (or extend
testEnvironmentAcquiaConfigPathOverride) to verify the fallback to
config_vcs_directory when DRUPAL_CONFIG_PATH is not set: clear/unset
DRUPAL_CONFIG_PATH in the environment, pre-populate/mock the settings array key
$settings['config_vcs_directory'] to a test path before including/loading the
Acquia settings logic, then assert that the resulting config path resolution
uses that $settings['config_vcs_directory'] value; reference the existing
testEnvironmentAcquiaConfigPathOverride behavior and the
$settings['config_vcs_directory'] symbol when implementing the mock and
assertions.

[coderabbitai]

🧹 Nitpick | 🔵 Trivial

Consider adding a test for the config_vcs_directory fallback path.

The test covers the DRUPAL_CONFIG_PATH override scenario but doesn't verify the fallback to config_vcs_directory when DRUPAL_CONFIG_PATH is absent. While the Acquia settings file that sets config_vcs_directory is excluded from coverage (due to file system dependencies), you could potentially mock this by pre-setting $settings['config_vcs_directory'] before including the settings file, if the test harness supports it.

🤖 Prompt for AI Agents

In `@tests/phpunit/Drupal/EnvironmentSettingsTest.php` around lines 781 - 785, Add
a new unit test (or extend testEnvironmentAcquiaConfigPathOverride) to verify
the fallback to config_vcs_directory when DRUPAL_CONFIG_PATH is not set:
clear/unset DRUPAL_CONFIG_PATH in the environment, pre-populate/mock the
settings array key $settings['config_vcs_directory'] to a test path before
including/loading the Acquia settings logic, then assert that the resulting
config path resolution uses that $settings['config_vcs_directory'] value;
reference the existing testEnvironmentAcquiaConfigPathOverride behavior and the
$settings['config_vcs_directory'] symbol when implementing the mock and
assertions.

[github-actions]

Code Coverage Report:
  2026-02-09 11:53:16

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.02% (173/184)

[AlexSkrypnyk]

Code Coverage Report:
  2026-02-09 11:53:21

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.02% (173/184)

[AlexSkrypnyk]

Code Coverage Report:
  2026-02-09 11:56:19

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.02% (173/184)

[AlexSkrypnyk]

Code Coverage Report:
  2026-02-09 11:56:54

 Summary:
  Classes:  0.00% (0/1)
  Methods:  0.00% (0/2)
  Lines:   94.02% (173/184)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.44%. Comparing base (72e6150) to head (2eec47f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2263      +/-   ##
==========================================
- Coverage   77.05%   76.44%   -0.61%     
==========================================
  Files         114      107       -7     
  Lines        5988     5829     -159     
  Branches       44        0      -44     
==========================================
- Hits         4614     4456     -158     
+ Misses       1374     1373       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.