-
-
Notifications
You must be signed in to change notification settings - Fork 28
[#2172] Added more information to docs about how we test Vortex. #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes add and restructure testing documentation within the Vortex project, introducing a new "Testing the template" section in the architecture guide and comprehensively reorganizing the tests documentation to describe unit tests, end-to-end tests, real-world validation via the DrevOps website, and the transition from Bats to PHPUnit. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.vortex/docs/content/contributing/maintenance/tests.mdx (1)
292-297:⚠️ Potential issue | 🟠 MajorFix demo/test image naming mismatch in test container image steps.
This section is about the test database container image, but the tag/push commands still reference the demo image names. That will publish the wrong images.
🐛 Proposed fix to align with test image naming
- docker tag drevops/vortex-dev-mariadb-drupal-data-demo-11.x:latest drevops/vortex-dev-mariadb-drupal-data-demo-destination-11.x:vortex-dev-database-ii - docker push drevops/vortex-dev-mariadb-drupal-data-demo-destination-11.x:vortex-dev-database-ii - - docker tag drevops/vortex-dev-mariadb-drupal-data-demo-11.x:latest drevops/vortex-dev-mariadb-drupal-data-demo-destination-11.x:vortex-dev-didi-database-fi - docker push drevops/vortex-dev-mariadb-drupal-data-demo-destination-11.x:vortex-dev-didi-database-fi + docker tag drevops/vortex-dev-mariadb-drupal-data-test-11.x:latest drevops/vortex-dev-mariadb-drupal-data-test-destination-11.x:vortex-dev-database-ii + docker push drevops/vortex-dev-mariadb-drupal-data-test-destination-11.x:vortex-dev-database-ii + + docker tag drevops/vortex-dev-mariadb-drupal-data-test-11.x:latest drevops/vortex-dev-mariadb-drupal-data-test-destination-11.x:vortex-dev-didi-database-fi + docker push drevops/vortex-dev-mariadb-drupal-data-test-destination-11.x:vortex-dev-didi-database-fi
|
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2262 +/- ##
==========================================
- Coverage 77.05% 76.44% -0.61%
==========================================
Files 114 107 -7
Lines 5988 5829 -159
Branches 44 0 -44
==========================================
- Hits 4614 4456 -158
+ Misses 1374 1373 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #2172
Summary by CodeRabbit