-
-
Notifications
You must be signed in to change notification settings - Fork 28
[#2249] Changed Renovate rangeStrategy to bump #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2250 +/- ##
==========================================
- Coverage 76.85% 76.22% -0.63%
==========================================
Files 112 105 -7
Lines 5846 5687 -159
Branches 44 0 -44
==========================================
- Hits 4493 4335 -158
+ Misses 1353 1352 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
|
Summary
rangeStrategyfromupdate-lockfiletobumpCloses #2249
Problem
With
config.bump-after-updateset totrueincomposer.json, PRs created by Renovate were failing because they only updated the lock file, notcomposer.json.Why Composer's
bump-after-updatedoesn't helpOne might expect that since Renovate runs
composer updateinternally, Composer'sbump-after-update: truesetting would automatically bump versions incomposer.json. However, Renovate controls what gets committed, not just what Composer does during the update process.The workflow is:
rangeStrategy, Renovate decides whether to modifycomposer.jsoncomposer updateto regenerate the lockfilerangeStrategyWith
rangeStrategy: update-lockfile, even if Composer'sbump-after-updatemodifiescomposer.json, Renovate discards those changes and only commitscomposer.lock.Solution
Changed
rangeStrategytobump, which tells Renovate to:composer.jsoncomposer updateto regenerate the lockfilecomposer.jsonandcomposer.lockReferences
Test plan
composer.jsonandcomposer.lockSummary by CodeRabbit