-
-
Notifications
You must be signed in to change notification settings - Fork 28
Updated CI runner to 26.1.0 #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated CI runner container image references from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/build-test-deploy.yml:
- Line 63: The workflow uses an unpinned image tag "drevops/ci-runner:canary" in
the database, build and deploy jobs causing unstable CI/CD; replace the floating
tag with a pinned release image (e.g., drevops/ci-runner:26.1.0@sha256:<digest>)
in the image fields for the database, build and deploy jobs, and ensure cache
keys (v26.1.0-db11-) remain consistent with that version; if this change was
meant only to test the canary, revert the image back to the previous pinned
digest and update the PR title/description to state it’s a temporary canary test
instead of replacing the release.
In @.github/workflows/vortex-test-common.yml:
- Line 27: The workflow jobs vortex-test-common and vortex-test-workflow are
using the floating image tag "drevops/ci-runner:canary", which can cause
non-deterministic CI; replace the canary tag with a pinned image version
(preferably using a SHA digest) for the image references in those jobs, or if
you intentionally want to exercise the canary before a release, document that
intent in the PR description and add a clear comment in the workflow near the
image lines to avoid accidental promotion of non-pinned images.
This comment has been minimized.
This comment has been minimized.
823871e to
4dc83e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.circleci/config.yml:
- Line 44: Replace the non-deterministic Docker image tag
"drevops/ci-runner:canary" with a specific version tag (e.g.,
"drevops/ci-runner:26.1.0") so the CircleCI job becomes deterministic; update
the image reference in the YAML where "drevops/ci-runner:canary" appears to use
the chosen stable version to match the project's version-pinning practice.
This comment has been minimized.
This comment has been minimized.
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
==========================================
- Coverage 76.85% 76.22% -0.63%
==========================================
Files 112 105 -7
Lines 5846 5687 -159
Branches 44 0 -44
==========================================
- Hits 4493 4335 -158
+ Misses 1353 1352 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4dc83e6 to
0848999
Compare
|
|
|
|
Summary by CodeRabbit