feat: add alignment options #737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xseman
changed the title
xseman
commented
Sep 25, 2025
Comment on lines
+348
to
+361
| let alignment_enable_all = get_value(&mut config, "alignment.enableAll", false, &mut diagnostics); | ||
|
|
||
| let resolved_config = Configuration { | ||
| /* alignment */ | ||
| alignment_enable_all, | ||
| variable_statement_align_assignments: get_value(&mut config, "variableStatement.alignAssignments", alignment_enable_all, &mut diagnostics), | ||
| object_expression_align_properties: get_value(&mut config, "objectExpression.alignProperties", alignment_enable_all, &mut diagnostics), | ||
| interface_declaration_align_properties: get_value(&mut config, "interfaceDeclaration.alignProperties", alignment_enable_all, &mut diagnostics), | ||
| type_literal_align_properties: get_value(&mut config, "typeLiteral.alignProperties", alignment_enable_all, &mut diagnostics), | ||
| class_declaration_align_properties: get_value(&mut config, "classDeclaration.alignProperties", alignment_enable_all, &mut diagnostics), | ||
| enum_declaration_align_members: get_value(&mut config, "enumDeclaration.alignMembers", alignment_enable_all, &mut diagnostics), | ||
| module_declaration_align_properties: get_value(&mut config, "moduleDeclaration.alignProperties", alignment_enable_all, &mut diagnostics), | ||
| // Copy all the previous fields from resolved_config | ||
| ..resolved_config |
Author
There was a problem hiding this comment.
Convenient way to enable all alignment, though I’m unsure if it’s right approach
Author
|
@dsherret I know you may be busy. This PR has been open for a while. Any feedback would help. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #483
I've also added alignment for