Skip to content

fix: support digest in FROM #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsherret merged 2 commits into from
Jun 2, 2025
Merged

fix: support digest in FROM #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fa5d9e
chore(deps): upgrade dockerfile-parser to 0.9.0
scop Mar 19, 2025
7023922
docs: point to actually used dockerfile-parser
scop Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ tracing = ["dprint-core/tracing"]

[dependencies]
anyhow = "1.0.62"
dockerfile-parser = "0.9.0-alpha.1"
dockerfile-parser = "0.9.0"
dprint-core = { version = "0.65.0", features = ["formatting"] }
serde = { version = "1.0.144", features = ["derive"] }
serde_json = { version = "1.0", optional = true }
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

Dockerfile code formatter plugin for [dprint](https://dprint.dev).

This uses [dockerfile-parser-rs](https://github.com/dsherret/dockerfile-parser-rs) to parse a dockerfile.
This uses [dockerfile-parser](https://crates.io/crates/dockerfile-parser) to parse a dockerfile.

See [releases](https://github.com/dprint/dprint-plugin-dockerfile/releases/) for usage.
6 changes: 3 additions & 3 deletions tests/specs/From/From_All.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ FROM base:${CODE_VERSION}
FROM test:tag
FROM test AS alias

== should format with digest -- todo: needs to be supported in parser (skip) ==
FROM test@digest
== should format with digest ==
FROM test@sha256:0000000000000000000000000000000000000000000000000000000000000000

[expect]
FROM test@digest
FROM test@sha256:0000000000000000000000000000000000000000000000000000000000000000

== should parse platform ==
FROM --platform=linux/amd64 node:lts-alpine
Expand Down
Loading