[TRTLLMINF-54][feat] Migrate retry consumers to classify() + isFinalAttempt fix

[dpitman-nvda]

@coderabbitai summary

Description

Commit 2 of 5 (classifier-consumers).

Migrates the three call sites of classifyInfraFailure() to the new classify(ex, scope). Behavior is unchanged for the SLURM and K8s retry paths EXCEPT for two intentional review-driven fixes:

1. Scope isolation for typed exceptions (review finding -- High). classify() now wraps a typed InfraFailure whose scope mismatches the caller's scope as a UserFailure, so an inner SLURM retry's typed typed:slurm-job-inactive exhaustion can no longer be re-retried by the outer K8s pod-launch retry that wraps the SLURM dispatcher pod. (The wrap is implemented inside classify() in the previous commit; this commit activates it by switching consumers to use classify().)

2. isFinalAttempt accuracy for PERSISTENT failures (review finding -- Medium). runKubernetesPodWithInfraRetry now tracks the prior attempt's severity in lastSeverity. If the previous attempt was PERSISTENT, the next attempt is the final one (effectiveMax=1), so isFinalAttempt is computed from the actual budget rather than the worst-case K8S_INFRA_RETRY_MAX. This means the inner cacheErrorAndUploadResult no longer suppresses synthetic stage-fail XML / junit() for what is actually the final attempt of an OOMKilled / "Connection failed" sequence, so the build's per-build test report records the failure instead of swallowing it.

Notes:

• The old e.toString().contains("FlowInterruptedException") and AbortException-exit-code-143 substring guards in the SLURM and K8s catch bodies are deleted; classify() returns PipelineInterruption for them and consumers rethrow on PipelineInterruption.
• The legacy classifyInfraFailure() function is intentionally retained in this commit so reviewers can diff old-vs-new classification behavior on the same input. It is deleted by the cleanup commit.
• [INFRA-RETRY] log line shape is preserved verbatim except for the field rename classification.matchedPattern -> c.detectedPattern. Dashboards and log scrapers keyed on the [INFRA-RETRY] prefix continue to work.

Test Coverage

N/A, this is a CI change

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.