Skip to content

Conversation

@vincent-gao
Copy link
Contributor

Jira

Problem/Motivation

Fix

Related PRs

Screenshots

TODO

@vincent-gao vincent-gao force-pushed the D11_upgrade branch 2 times, most recently from 91b6d36 to 8938527 Compare January 21, 2026 05:35
description: 'Blockquote with 2 lines of caption'
thumb: { }
code: "<blockquote class=\"quotation\">\r\n<p>Berios sim destrum facientota nis ex eost aut prae vendis explam aliquis dolorpo rrorem reptaep elenis net.</p>\r\n\r\n<footer><cite><span class=\"quotation__author\">Her Excellency the Honourable Linda Dessau AC</span><br />\r\n<span class=\"quotation__author-title\">Governor of Victoria</span> </cite></footer>\r\n</blockquote>\r\n"
code:
Copy link
Contributor Author

@vincent-gao vincent-gao Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] This needs an update hook.

- '<th align class>'
- '<td align class>'
- '<p class="quotation__quote">'
ckeditor5_list:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] This needs an update hook.

delta_first_last: false
multi_type: separator
separator: ', '
field_api_classes: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] Investigate the cause of the tide_media_browser failure due to the missing field_secure_file_target_id.

multi_type: separator
separator: ', '
field_api_classes: false
filemime_1:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] Investigate the cause of the tide_media_browser failure due to the missing field_secure_file_target_id.

COMPOSER=${COMPOSER:-composer.build.json}
APP=${APP:-/app}
WEBROOT=${WEBROOT:-docroot}
TEST_PACKAGE_NAME=${TEST_PACKAGE_NAME:-tide_test}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] check if this part needs to removed from automation

"drupal/core-composer-scaffold": "^11.0",
"drupal/core": "10.5.2",
"drupal/core-recommended": "10.5.2",
"drupal/core": "11.x",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] This needs to be changed to 11.3.x

"drupal": {
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": ["drupal/token_conditions", "drupal/ckeditor_templates", "drupal/create_menus_permission"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] check why do we need the customised "drupal/token_conditions", "drupal/ckeditor_templates", "drupal/create_menus_permission"


mariadb:
image: "ghcr.io/dpc-sdp/bay/mariadb:${BAY_IMAGE_VERSION:-6.x}"
image: "uselagoon/mariadb-10.6-drupal:latest"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] D11 needs mariadb-10.6+


redis:
image: amazeeio/redis
image: uselagoon/redis-5:latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] why did I set it to uselagoon/redis-5:latest ???

- entity_reference_revisions:entity_reference_revisions
- quick_node_clone:quick_node_clone
- ckeditor5_embedded_content:ckeditor5_embedded_content
- embedded_content:embedded_content
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] we have to migrate from ckeditor5_embedded_content to embedded_content

"extra": {
"patches": {
"drupal/admin_audit_trail": {
"Add an option to allow logging in CLI - https://www.drupal.org/project/admin_audit_trail/issues/3263615#comment-16412890": "https://www.drupal.org/files/issues/2026-01-15/3263615-admin_audit_trail-option-for-cli-10.patch"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] check patches.

"drupal/core-composer-scaffold": true
},
"audit": {
"ignore": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] use "block-insecure": false

scheme: public
directory: inline-images
max_size: ''
max_size: '10MB'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] it needs an update hook.

ckeditor5_list:
reversed: true
startIndex: true
properties:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] It needs an update hook.

status: true
dependencies:
module:
- ckeditor5_embedded_content
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NOTE] this needs to move to tide_ckeditor module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants