lib-oauth2: jwt - Avoid use-after-realloc of jwt_node front pointer#289
Open
rootvector2 wants to merge 1 commit into
Open
lib-oauth2: jwt - Avoid use-after-realloc of jwt_node front pointer#289rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
oauth2_jwt_copy_fields() takes subroot via array_front(&nodes) and then calls array_append_space(&nodes) inside the inner loop. When the append cannot extend the nodes buffer in place, it relocates the buffer, leaving the captured subroot pointer aliasing the previous slot; subsequent reads of subroot->prefix and subroot->array end up operating on the abandoned location. Copy the front node by value before the append so the prefix/array references remain valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oauth2_jwt_copy_fields() captures subroot from array_front(&nodes)
then calls array_append_space(&nodes) inside the inner loop. When the
append cannot extend the buffer in place it relocates it, so subroot
aliases the previous slot and later subroot->prefix / subroot->array
reads operate on the abandoned location. Copy the front node by value
before the append.