-
-
Notifications
You must be signed in to change notification settings - Fork 374
fix(PdfReader): render twice if url is null #7487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The PR title and description focus on a PdfReader fix, but the only changed file is BootstrapBlazor.Server.csproj; please ensure the title/description accurately reflect the actual change or include the missing code changes.
- Since the csproj configuration was adjusted, consider briefly explaining in the description what was changed in the build configuration and why, to make the intent of this change clearer to reviewers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title and description focus on a PdfReader fix, but the only changed file is BootstrapBlazor.Server.csproj; please ensure the title/description accurately reflect the actual change or include the missing code changes.
- Since the csproj configuration was adjusted, consider briefly explaining in the description what was changed in the build configuration and why, to make the intent of this change clearer to reviewers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the BootstrapBlazor.PdfReader package dependency to version 10.0.26 to fix a rendering issue where the component would render twice when the URL parameter is null.
Changes:
- Bump BootstrapBlazor.PdfReader package version from 10.0.25 to 10.0.26
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7487 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 32943 32943
Branches 4577 4577
=========================================
Hits 32943 32943
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7486
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Build: