Fix issue 14089: Disabled menu items incorrectly display highlighted text in dark mode with System renderer

[SimonZhao888]

Fixes #14089

Proposed changes

• Fixed a regression where disabled menu items in dark mode would display highlighted text when focused using mouse cursor, making them appear enabled. This issue only occurs when RenderMode is set to System and the application runs under dark mode.

Customer Impact

• When using the system renderer, disabled menu items incorrectly no longer highlight text in dark mode.

Regression?

• Yes

Risk

• Min

Screenshots

Before

ActualResults.mp4

After

Bug14089.mp4

Test methodology

• Manually

Test environment(s)

• 11.0.0-alpha.1.25619.109

Microsoft Reviewers: Open in CodeFlow

[Copilot]

Pull request overview

This PR fixes a regression in the System renderer for dark mode where disabled menu items incorrectly displayed highlighted text when focused with the mouse cursor, making them appear enabled.

Changes:

• Reordered the conditional logic in OnRenderItemText to prioritize the disabled state check, ensuring disabled items always display with gray text regardless of selection or pressed state

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.18255%. Comparing base (86f2d9a) to head (0d5ce84).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #14248         +/-   ##
===================================================
+ Coverage   77.17712%   77.18255%   +0.00543%     
===================================================
  Files           3279        3279                 
  Lines         645129      645129                 
  Branches       47728       47728                 
===================================================
+ Hits          497892      497927         +35     
+ Misses        143544      143510         -34     
+ Partials        3693        3692          -1     

Flag	Coverage Δ
Debug	77.18255% <0.00000%> (+0.00543%)	⬆️
integration	19.02191% <0.00000%> (+0.03310%)	⬆️
production	52.05926% <0.00000%> (+0.01217%)	⬆️
test	97.40479% <ø> (ø)
unit	49.49340% <0.00000%> (+0.00661%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.