Skip to content

PropertyGridView: Prevent out-of-range access when committing next enumerable value #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeafShi1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PropertyGridView: Prevent out-of-range access when committing next enumerable value #14182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1004a4a
Prevent out-of-range access when committing next enumerable value
LeafShi1 Jan 5, 2026
6873346
Fix PropertyGridView.OnMouseWheel - IndexOutOfRangeException
LeafShi1 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...Forms/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/PropertyGridView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,6 +1298,12 @@ public void DoubleClickRow(int row, bool toggleExpand, int type)
{
object[] values = gridEntry.GetPropertyValueList();

// If values.Length is 0, we can't cycle through anything.
if (values.Length == 0)
{
return;
}
Comment thread
LeafShi1 marked this conversation as resolved.

if (index >= (values.Length - 1))
{
index = 0;
Expand Down Expand Up @@ -3177,6 +3183,12 @@ protected override void OnMouseWheel(MouseEventArgs e)
int delta = e.Delta > 0 ? -1 : 1;
object[] values = _selectedGridEntry.GetPropertyValueList();

// Prevent out-of-range access
if (values.Length == 0)
{
return;
}
Comment thread
LeafShi1 marked this conversation as resolved.

if (delta > 0 && index >= (values.Length - 1))
{
index = 0;
Expand Down
Loading