Conversation
|
@radical PTAL |
|
@jjonescz Could you please help me understand why this is needed? Can you share links to the failures being hit? |
|
Here are the errors currently in main builds: You can also see that many MSBuild assemblies are missing from the deployment due to these errors: https://source.dot.net/#q=assembly%20Microsoft.Build These errors should not be present in the build of this PR which I linked in the description. |
|
@radical could we merge this? I'd like the missing repos to appear again in the source index. |
|
This is not the correct fix. We shouldn't need to update the sdk here for fix that error. Instead, the correct sdk version should be used in that step. I'm looking at the issue now. |
|
I guess that makes sense, thanks, I'm not that familiar with this repo, I just recreated my previous fix. |
|
I started a draft follow-up fix here: #249. |
|
Closing in favor of #250 . |
Similar to #226 (fixes similar errors that are appearing in the build now).
Validation run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2920211&view=results