Fix static analysis findings in GC bridge and NativeAOT runtime by Copilot · Pull Request #127893 · dotnet/runtime

Copilot · 2026-05-06T23:55:39Z

Note

This PR description was generated with AI assistance.

Summary

Fixed allocator mismatch in src/coreclr/gc/gcbridge.cpp by replacing free with delete[] for memory allocated via new[].
Fixed potential null-dereference path in NativeAOT stress log by replacing heap-allocated CrstStatic with inline minipal_mutex, and asserting that minipal_mutex_init succeeds.
Fixed invalid handle cleanup in src/coreclr/nativeaot/Runtime/windows/PalMinWin.cpp by guarding CloseHandle calls for hMap and hFile.
Replaced CRITSEC_COOKIE lock with minipal_mutex lock in src/coreclr/inc/stresslog.h (mirroring the same change already made in the NativeAOT stress log header), and updated src/coreclr/utilcode/stresslog.cpp to use minipal_mutex_init, minipal_mutex_enter, and minipal_mutex_leave accordingly.

Validation

Baseline build before edits: ./build.sh clr+libs+host (pass)
Post-change build: ./build.sh clr+libs+host (pass)
Parallel validation:
- Code Review: pass (no remaining comments)
- CodeQL: no alerts (analysis skipped due to DB size limit)

Notes

Incorporated PR feedback to use bool success; success = minipal_mutex_init(&theLog.lock); _ASSERTE(success); instead of returning on initialization failure.
The StressLogLockHolder typedef in stresslog.h was updated from Holder<CRITSEC_COOKIE, ...> to Holder<minipal_mutex*, ...>, and call sites updated to pass &theLog.lock.
No focused runtime test suite was run for these specific low-level internal changes in this environment; full component build succeeded before and after changes.

…nk handle cleanup Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f253b77c-d18d-4f6c-b8ed-9abbe61cfd38 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f253b77c-d18d-4f6c-b8ed-9abbe61cfd38 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

dotnet-policy-service · 2026-05-07T00:01:32Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a17e077c-3c26-46f1-9178-bdd6980712d1 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

+    bool success;
+    success = minipal_mutex_init(&theLog.lock);
+    _ASSERTE(success);


…g.h and update stresslog.cpp Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/26128bb6-29c4-4931-9bcb-12d921bc1f7a Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

…OT stressLog.cpp Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/26128bb6-29c4-4931-9bcb-12d921bc1f7a Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas · 2026-05-07T01:05:03Z

 #endif

-typedef Holder<CRITSEC_COOKIE, StressLog::Enter, StressLog::Leave, 0, CompareDefault<CRITSEC_COOKIE>> StressLogLockHolder;
+typedef Holder<minipal_mutex*, StressLog::Enter, StressLog::Leave, 0, CompareDefault<minipal_mutex*>> StressLogLockHolder;


@copilot Delete this and replace it with minipal::MutexHolder

Done in commit 346077a7. Deleted the StressLogLockHolder typedef and the Enter/Leave static methods. Updated Terminate and CreateThreadStressLog in stresslog.cpp to use minipal::MutexHolder directly.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/d3a0bfa0-0985-471c-9daf-95a6dfaaf158 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

…path Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/d3a0bfa0-0985-471c-9daf-95a6dfaaf158 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas · 2026-05-07T01:52:13Z

@copilot Revert last two commits. They do not look like an improvement

… comments) Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/9fbcca80-de7f-4686-a0ea-6c342340a4f9 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2026-05-07T01:56:05Z

@copilot Revert last two commits. They do not look like an improvement

Done in commit cf6e7797. Both src/coreclr/inc/stresslog.h and src/coreclr/utilcode/stresslog.cpp have been reverted to their state before those two commits.

Copilot AI and others added 2 commits May 6, 2026 23:49

Fix static analysis issues in gcbridge, NativeAOT stress log, and thu…

64ef1e6

…nk handle cleanup Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f253b77c-d18d-4f6c-b8ed-9abbe61cfd38 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Handle minipal mutex initialization failure in NativeAOT stress log

1d64962

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f253b77c-d18d-4f6c-b8ed-9abbe61cfd38 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI assigned Copilot and jkotas May 6, 2026

Copilot AI requested review from Copilot and removed request for Copilot May 6, 2026 23:55

Copilot created this pull request from a session on behalf of jkotas May 6, 2026 23:56 View session

Copilot finished work on behalf of jkotas May 6, 2026 23:56

Copilot AI requested a review from jkotas May 6, 2026 23:56

github-actions Bot added the area-NativeAOT-coreclr label May 7, 2026

jkotas reviewed May 7, 2026

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/stressLog.cpp Outdated

Copilot started work on behalf of jkotas May 7, 2026 00:00 View session

jkotas marked this pull request as ready for review May 7, 2026 00:01

jkotas requested a review from MichalStrehovsky as a code owner May 7, 2026 00:01

Copilot AI review requested due to automatic review settings May 7, 2026 00:01

jkotas approved these changes May 7, 2026

View reviewed changes

Copilot started reviewing on behalf of jkotas May 7, 2026 00:01 View session

jkotas requested a review from BrzVlad May 7, 2026 00:03

jkotas closed this May 7, 2026

jkotas reopened this May 7, 2026

Assert minipal_mutex_init success in NativeAOT stress log

2789752

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a17e077c-3c26-46f1-9178-bdd6980712d1 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI reviewed May 7, 2026

View reviewed changes

Copilot AI requested a review from jkotas May 7, 2026 00:23

Copilot finished work on behalf of jkotas May 7, 2026 00:23

jkotas reviewed May 7, 2026

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/stressLog.cpp Outdated

Update src/coreclr/nativeaot/Runtime/stressLog.cpp

60bc8f8

Copilot AI review requested due to automatic review settings May 7, 2026 00:29

Copilot started reviewing on behalf of jkotas May 7, 2026 00:29 View session

jkotas reviewed May 7, 2026

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/inc/stressLog.h

Copilot started work on behalf of jkotas May 7, 2026 00:34 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/stressLog.cpp Outdated

jkotas reviewed May 7, 2026

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/stressLog.cpp Outdated

Update src/coreclr/nativeaot/Runtime/stressLog.cpp

26d858c

Copilot AI review requested due to automatic review settings May 7, 2026 00:43

Copilot started reviewing on behalf of jkotas May 7, 2026 00:44 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/inc/stressLog.h

Comment thread src/coreclr/nativeaot/Runtime/stressLog.cpp Outdated

Comment on lines +98 to +100

bool success;

success = minipal_mutex_init(&theLog.lock);

_ASSERTE(success);

Copilot AI and others added 2 commits May 7, 2026 00:51

Replace CRITSEC_COOKIE with minipal_mutex in src/coreclr/inc/stresslo…

7d19e07

…g.h and update stresslog.cpp Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/26128bb6-29c4-4931-9bcb-12d921bc1f7a Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Fix null assertions in Enter/Leave and combine declaration in NativeA…

5d269f5

…OT stressLog.cpp Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/26128bb6-29c4-4931-9bcb-12d921bc1f7a Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 00:54

Copilot finished work on behalf of jkotas May 7, 2026 00:55

Copilot AI requested a review from jkotas May 7, 2026 00:55

jkotas reviewed May 7, 2026

View reviewed changes

Copilot started work on behalf of jkotas May 7, 2026 01:05 View session

Replace StressLogLockHolder with minipal::MutexHolder in stresslog.h/cpp

346077a

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/d3a0bfa0-0985-471c-9daf-95a6dfaaf158 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 01:33

Add clarifying comments for callerID pattern and process-detach free …

e78b6fe

…path Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/d3a0bfa0-0985-471c-9daf-95a6dfaaf158 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 01:35

Copilot finished work on behalf of jkotas May 7, 2026 01:36

Copilot AI requested a review from jkotas May 7, 2026 01:36

Copilot started work on behalf of jkotas May 7, 2026 01:52 View session

Revert last two commits (Replace StressLogLockHolder / Add clarifying…

cf6e779

… comments) Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/9fbcca80-de7f-4686-a0ea-6c342340a4f9 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 01:56

Copilot finished work on behalf of jkotas May 7, 2026 01:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix static analysis findings in GC bridge and NativeAOT runtime#127893

Fix static analysis findings in GC bridge and NativeAOT runtime#127893
Copilot wants to merge 10 commits intomainfrom
copilot/fix-static-analysis-issues

Copilot AI commented May 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

dotnet-policy-service Bot commented May 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

jkotas May 7, 2026

Uh oh!

Copilot AI May 7, 2026

Uh oh!

jkotas commented May 7, 2026

Uh oh!

Copilot AI commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Notes

Uh oh!

Uh oh!

dotnet-policy-service Bot commented May 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jkotas May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas commented May 7, 2026

Uh oh!

Copilot AI commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 6, 2026 •

edited

Loading