Remove redundant NULL check for pDir in ClrDataAccess::GetMetaDataFileInfoFromPEFile

[Copilot]

pDir was declared as IMAGE_DATA_DIRECTORY *pDir = NULL and immediately tested with if (pDir == NULL || pDir->Size == 0) — always true, making the entire block dead code. Flagged by SVACE static analysis (Linux Verification Center).

Changes

• src/coreclr/debug/daccess/daccess.cpp
  • Removed unused IMAGE_DATA_DIRECTORY *pDir local variable
  • Removed always-true if (pDir == NULL || pDir->Size == 0) wrapper, flattening the logic
  • Inlined pDir->Size → layout->GetCorHeader()->MetaData.Size

Before:

IMAGE_DATA_DIRECTORY *pDir = NULL;
// ...
if (pDir == NULL || pDir->Size == 0)  // always true
{
    mdImage = pPEAssembly->GetPEImage();
    if (mdImage != NULL)
    {
        layout = mdImage->GetLoadedLayout();
        pDir = &layout->GetCorHeader()->MetaData;
        dwRvaHint = 0;
        dwDataSize = pDir->Size;
    }
    else { return false; }
}

After:

mdImage = pPEAssembly->GetPEImage();
if (mdImage != NULL)
{
    layout = mdImage->GetLoadedLayout();
    dwRvaHint = 0;
    dwDataSize = layout->GetCorHeader()->MetaData.Size;
}
else { return false; }

No semantic behavior change.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Redundant NULL check for pDir in ClrDataAccess::GetMetaDataFileInfoFromPEFile</issue_title>
<issue_description>### Description

In daccess.cpp, the variable pDir is initialized to NULL and immediately checked with if (pDir == NULL || pDir->Size == 0). Since pDir is always NULL at this point, the condition is always true and the check is redundant.

Reproduction Steps

See ClrDataAccess::GetMetaDataFileInfoFromPEFile in daccess.cpp:
cppIMAGE_DATA_DIRECTORY *pDir = NULL;
// ...
if (pDir == NULL || pDir->Size == 0) // always true

Expected behavior

The condition should either be removed or restructured to reflect actual intent.

Actual behavior

The if condition is always true because pDir is always NULL at that point. Static analysis tools flag this as unreachable/redundant code

Regression?

N/A

Known Workarounds

None

Configuration

this is a code quality issue, not runtime-specific.

Other information

Found by Linux Verification Center (linuxtesting.org) with SVACE.</issue_description>

<agent_instructions>Delete unnecessary check</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes Redundant NULL check for pDir in ClrDataAccess::GetMetaDataFileInfoFromPEFile #125477

---

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Removes dead code in ClrDataAccess::GetMetaDataFileInfoFromPEFile by eliminating an always-true pDir == NULL check and simplifying metadata size retrieval, addressing static analysis findings (SVACE).

Changes:

• Removed redundant IMAGE_DATA_DIRECTORY* pDir local and the always-true if (pDir == NULL || ...) wrapper.
• Simplified flow to directly fetch mdImage/layout and read MetaData.Size from the COR header.