Add tests for lazy quantifier inside optional group#125474
Merged
danmoseley merged 1 commit intodotnet:mainfrom Mar 12, 2026
Merged
Add tests for lazy quantifier inside optional group#125474danmoseley merged 1 commit intodotnet:mainfrom
danmoseley merged 1 commit intodotnet:mainfrom
Conversation
Add test cases for the pattern a(b.*?c)?d to confirm the fix from PR dotnet#124254 addresses the regression reported in dotnet#125321, where a lazy quantifier inside an optional group incorrectly failed to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds four test cases for the regex pattern a(b.*?c)?d to the existing Match_MemberData_Cases test data provider, verifying the fix from PR #124254 for the regression reported in issue #125321 where a lazy quantifier inside an optional group incorrectly failed to match.
Changes:
- Added four
yield returnentries covering lazy-must-expand, lazy-zero-width, optional-group-skipped, and no-match scenarios for thea(b.*?c)?dpattern.
You can also share your feedback on Copilot code review. Take the survey.
2 tasks
danmoseley
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test cases for the pattern
a(b.*?c)?dto confirm the fix from #124254 addresses the regression reported in #125321, where a lazy quantifier inside an optional group incorrectly failed to match.Tests cover:
abccd— lazy.*?must grow past firstcfordto matchabcd— lazy.*?matches nothing,canddalign immediatelyad— the entire(b.*?c)?group is bypassedabce— nodavailable, match correctly fails