-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Delete obsolete ETW logging scripts and update System.Net telemetry documentation #123518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
|
@copilot Let's keep the ParallelTestExecution.ps1 file |
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Done. Restored ParallelTestExecution.ps1 in 838cabf. |
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request removes obsolete ETW (Event Tracing for Windows) logging helper scripts and updates documentation to direct users to the official Microsoft Learn networking telemetry documentation instead of maintaining a local list of event sources.
Changes:
- Deletes three obsolete ETW logging helper scripts (
net_startlog.cmd,net_stoplog.cmd, andnet_providers.txt) - Updates System.Net debugging documentation to reference the official Microsoft Learn telemetry overview page
- Removes a hardcoded list of 10 Microsoft-System-Net-* event sources from the documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/libraries/Common/tests/Scripts/Tools/net_stoplog.cmd |
Deleted obsolete ETW logging stop script |
src/libraries/Common/tests/Scripts/Tools/net_startlog.cmd |
Deleted obsolete ETW logging start script |
src/libraries/Common/tests/Scripts/Tools/net_providers.txt |
Deleted obsolete ETW provider list containing GUIDs for networking event sources |
docs/workflow/debugging/libraries/windows-instructions.md |
Replaced local script references and event source list with link to official Microsoft Learn telemetry documentation |
Description
Removes obsolete ETW logging helper scripts and redirects users to the official Microsoft Learn networking telemetry documentation. Preserves the ParallelTestExecution.ps1 utility script for parallel test execution.
Changes
Deleted files:
src/libraries/Common/tests/Scripts/Tools/net_startlog.cmdsrc/libraries/Common/tests/Scripts/Tools/net_stoplog.cmdsrc/libraries/Common/tests/Scripts/Tools/net_providers.txtKept files:
src/libraries/Common/tests/Scripts/Tools/ParallelTestExecution.ps1- PowerShell utility script for running tests in parallelDocumentation updates:
docs/workflow/debugging/libraries/windows-instructions.mdwith link to https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/telemetry/overviewThe System.Net namespaces section now directs users to comprehensive, maintained telemetry documentation instead of local scripts and potentially stale event source lists.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.