Skip to content

Handle more than 64 registers - Part 4 #102673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kunalspathak wants to merge 50 commits into from
Closed

Handle more than 64 registers - Part 4 #102673

kunalspathak wants to merge 50 commits into from

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented May 24, 2024 •
edited
Loading

  • Adds a high field in regMaskTP only for Arm64
  • Moved some of the assignment overloaded operator to regMaskTP as instance methods to directly update the low field.

To check the changes that are made on top of #102592, please see kunalspathak#2.

Depends on #102592

kunalspathak added 30 commits May 14, 2024 22:13
@kunalspathak
Add high in regMaskTP
cec9ad9
@kunalspathak
Introduce SingleTypeRegSet
5fa863e
@kunalspathak
Use SingleTypeRegSet in few places
7dba61b
@kunalspathak
Delete some methods in regMaskTP
f68cf05
@kunalspathak
Delete some more methods of regMaskTP
7f8a9b6
@kunalspathak
Fix actualRegistersMask
2ede666
@kunalspathak
Use SingleTypeRegSet in consecutive register code
4b873d4
@kunalspathak
Use SingleTypeRegSet in consecutive registers codebase
98caccf
@kunalspathak
Change genRegMask*() method to return SingleTypeRegSet
dbb72eb
@kunalspathak
wip
36d5919
@kunalspathak
another wip
a647a65
@kunalspathak
Everything except newRefPosition/killMask
9a15670
@kunalspathak
refactor code around buildkill
5e739a4
@kunalspathak
fix build errors
e93f528
@kunalspathak
some more errors
05b09b2
@kunalspathak
jit format
f00f7a8
@kunalspathak
Merge remote-tracking branch 'kp/lsra-refactor' into more-than-64-par…
d356c89 
…t2-kill
@kunalspathak
fixed build error for arm64
06bd9e2
@kunalspathak
REVERT: temporary add #ifdef TARGET_ARM64 for accessing regMaskTP met…
325bc6e 
…hods
@kunalspathak
Merge remote-tracking branch 'origin/main' into more-than-64-part2-kill
92378d5
@kunalspathak
forgot to add the new file
e96428f
@kunalspathak
make addRegsForKill only on low
1cf6b7a
@kunalspathak
jit format
bf86515
@kunalspathak
Merge remote-tracking branch 'origin/main' into more-than-64-part2-kill
2065ba3
@kunalspathak
Revert "REVERT: temporary add #ifdef TARGET_ARM64 for accessing regMa…
7d566b4 
…skTP methods"

This reverts commit 325bc6e.
@kunalspathak
Various fixes after merge
1963c98
@kunalspathak
passing arm64 build
31498ef
@kunalspathak
clrjit build works
f17257d
@kunalspathak
clrjit_universal_arm_x64 build works
a85312d
@kunalspathak
clrjit_unix_x64_x64 build works
d7c1010
kunalspathak added 18 commits May 22, 2024 18:29
@kunalspathak
clrjit_win_x86_x64 build works
ba4ef0d
@kunalspathak
fix a bug in size
1868424
@kunalspathak
delete unwanted method
384fef8
@kunalspathak
Merge remote-tracking branch 'origin/main' into more-than-64-part2
b9181bc
@kunalspathak
jit format
f0ef2bc
@kunalspathak
Remove high
db03c23
@kunalspathak
Continue using regMaskTP for NodeInternalRegisters
d094109
@kunalspathak
Pass regType to getConstrainedRegMask()
ca77f79
@kunalspathak
jit format
e0b87d4
@kunalspathak
fix a wrong parameter for consecutive register
5b65ddc
@kunalspathak
fix riscv64 build errors
494d862
@kunalspathak
Merge remote-tracking branch 'origin/main' into more-than-64-part2
baecc25
@kunalspathak
Merge remote-tracking branch 'kp/more-than-64-part2' into more-than-6…
aabb072 
…4-part2
@kunalspathak
jit format
eb4515d
@kunalspathak
Add high field
95abd7c
@kunalspathak
Do not use const regMaskTP& as parameter
d53b620
@kunalspathak
Revert "Do not use const regMaskTP& as parameter"
e2c0f03 
This reverts commit d53b620.

By not passing `regMaskTP` using constant reference, there is a small cost
we have to pay:

Without constant reference:
Overall: 1.80%
MinOpts: 2.05%
FullOpts: 1.62%

With constant reference:
Overall: 1.74%
MinOpts: 1.94%
FullOpts: 1.6%
@kunalspathak
Furture reduce the TP cost
9086ad8 
Moved the *= operators as instance of `regMaskTP` so the `.low`
private field can directly be manipulated instead of converting
the `64-bit` value in `regMaskTP` before doing any operation.

Overall: 0.74%
MinOpts: 0.82%
FullOpts: 0.68%
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 24, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented May 24, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak
Copy link
Contributor Author

kunalspathak commented May 28, 2024

Made some more changes. I will send a fresh PR.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kunalspathak kunalspathak

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kunalspathak