Skip to content

Conversation

@rolfbjarne
Copy link
Member

In particular use static libraries when using any runtime on device.

In particular use static libraries when using any runtime on device.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the computation of _LibMonoLinkMode when not using the Mono runtime, ensuring that static libraries are used for device builds with NativeAOT. The change corrects the MSBuild logic to properly handle different runtime types (MonoVM, CoreCLR, NativeAOT) and platforms.

  • Refactored _LibMonoLinkMode computation to properly handle NativeAOT and CoreCLR runtimes
  • Updated logic to enforce static linking for iOS/tvOS device builds (except temporary CoreCLR exception)
  • Updated test expectations to reflect smaller app bundle size due to static linking

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
dotnet/targets/Xamarin.Shared.Sdk.targets Refactored _LibMonoLinkMode conditions to properly differentiate between MonoVM, CoreCLR, and NativeAOT runtimes, ensuring static linking on device builds
tests/dotnet/UnitTests/expected/iOS-NativeAOT-size.txt Updated expected app bundle size to reflect removal of dynamic libraries (.dylib files) in favor of static linking, reducing total size from 3.8 MB to 2.5 MB

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #e7646da] Build passed (Build packages) ✅

Pipeline on Agent
Hash: e7646da67e67a4c945f4c71013bdb25c2f75b029 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #e7646da] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: e7646da67e67a4c945f4c71013bdb25c2f75b029 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e7646da] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: e7646da67e67a4c945f4c71013bdb25c2f75b029 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e7646da] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: e7646da67e67a4c945f4c71013bdb25c2f75b029 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e7646da] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: e7646da67e67a4c945f4c71013bdb25c2f75b029 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #e7646da] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: e7646da67e67a4c945f4c71013bdb25c2f75b029 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne enabled auto-merge (squash) January 8, 2026 16:31
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #e7646da] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: e7646da67e67a4c945f4c71013bdb25c2f75b029 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e7646da67e67a4c945f4c71013bdb25c2f75b029 [PR build]

@rolfbjarne rolfbjarne merged commit fbf9398 into net11.0 Jan 9, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants