Skip to content

Fix quoting in build.sh#19570

Open
omajid wants to merge 1 commit intodotnet:mainfrom
omajid:fsharp-build-sh-quoting
Open

Fix quoting in build.sh#19570
omajid wants to merge 1 commit intodotnet:mainfrom
omajid:fsharp-build-sh-quoting

Conversation

@omajid
Copy link
Copy Markdown
Member

@omajid omajid commented Apr 10, 2026

Description

This allows it to accept arguments that contain spaces, such as propreties like "/p:OfficialBuilder=Foo Bar".

Fixes the regression introduced in #19211

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

I can't add labels 😆

This allows it to accept arguments that contain spaces, such as
propreties like "/p:OfficialBuilder=Foo Bar".

Fixes the regression introduced in dotnet#19211
@github-actions
Copy link
Copy Markdown
Contributor

✅ No release notes required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

1 participant