Enhance the compiler to produce a FS0750 error on let! or use! outside a CE#19347
Open
evgTSV wants to merge 5 commits intodotnet:mainfrom
Open
Enhance the compiler to produce a FS0750 error on let! or use! outside a CE#19347evgTSV wants to merge 5 commits intodotnet:mainfrom
evgTSV wants to merge 5 commits intodotnet:mainfrom
Conversation
Contributor
❗ Release notes required
|
vzarytovskii
previously approved these changes
Feb 22, 2026
Member
|
Release notes should go to 10.0.300, not 9.0.200 |
Contributor
Author
Yeah, I got it |
auduchinok
reviewed
Feb 22, 2026
…nch. Add one more test.
Contributor
Author
|
I have to fix tests. Besides, I found that a case where let! is used together with and! doesn't trigger any errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the active pattern
LetOrUsewas unreachable due to the commonSynExpr.LetOrUse _, I've put the active pattern aboveSynExpr.LetOrUse _Fixes #19345
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: