Skip to content

Comments

Enhance the compiler to produce a FS0750 error on let! or use! outside a CE#19347

Open
evgTSV wants to merge 5 commits intodotnet:mainfrom
evgTSV:fix-bangs-outside-ce
Open

Enhance the compiler to produce a FS0750 error on let! or use! outside a CE#19347
evgTSV wants to merge 5 commits intodotnet:mainfrom
evgTSV:fix-bangs-outside-ce

Conversation

@evgTSV
Copy link
Contributor

@evgTSV evgTSV commented Feb 22, 2026

Description

As the active pattern LetOrUse was unreachable due to the common SynExpr.LetOrUse _, I've put the active pattern above SynExpr.LetOrUse _

Fixes #19345

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2026

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.300.md

vzarytovskii
vzarytovskii previously approved these changes Feb 22, 2026
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Feb 22, 2026
@vzarytovskii
Copy link
Member

Release notes should go to 10.0.300, not 9.0.200

@evgTSV
Copy link
Contributor Author

evgTSV commented Feb 22, 2026

Release notes should go to 10.0.300, not 9.0.200

Yeah, I got it

@vzarytovskii vzarytovskii dismissed their stale review February 22, 2026 11:06

Erroneously approved

Copy link
Member

@auduchinok auduchinok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@evgTSV
Copy link
Contributor Author

evgTSV commented Feb 22, 2026

I have to fix tests. Besides, I found that a case where let! is used together with and! doesn't trigger any errors.

Copy link
Member

@auduchinok auduchinok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

let! is allowed outside of computation expressions

3 participants