WIP :: Bugfix :: Fix emitted method signatures and calling conventions#19340
Draft
WIP :: Bugfix :: Fix emitted method signatures and calling conventions#19340
Conversation
Contributor
✅ No release notes required |
T-Gro
force-pushed
the
codegen/fix-method-signatures
branch
3 times, most recently
from
88fbc57 to
3a393bd
Compare
Fix 4 codegen bugs in method call emission and parameter metadata: - #13468: outref parameter compiled as byref - #18135: Static abstract interface members with byref params - #18140: callvirt on value types causes ILVerify errors - #18374: RuntimeWrappedException cannot be caught Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
codegen/fix-method-signatures
branch
from
3a393bd to
4b98317
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect method signatures and calling conventions in emitted IL.
outrefparameter from an interface method is compiled asbyrefparameter #13468 —outrefparameters now correctly emitted as[out] byrefinstead of plainbyrefconstrained.callvirtemitted for method calls on value types