WIP :: Bugfix :: Fix closure capture and let-rec initialization codegen#19339
Draft
WIP :: Bugfix :: Fix closure capture and let-rec initialization codegen#19339
Conversation
Contributor
✅ No release notes required |
T-Gro
force-pushed
the
codegen/fix-closures-and-letrec
branch
4 times, most recently
from
457e616 to
78ae056
Compare
Fix 3 codegen bugs in closure generation and initialization: - #19068: Object expressions in struct types generate invalid IL with byref fields - #17692: Duplicate parameter names in closure constructors - #12384: let-rec mutual recursion initialization order for mixed lambda/value bindings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
codegen/fix-closures-and-letrec
branch
from
78ae056 to
e2ddcab
Compare
auduchinok
reviewed
Feb 23, 2026
Comment on lines
+395
to
+396
| // Note: This is similar to ChooseFreeVarNames in IlxGen.fs but operates on | ||
| // IlxClosureFreeVar[] instead of string lists. Kept separate to avoid cross-file dependency. |
Member
There was a problem hiding this comment.
Can this be extracted and unified somehow instead? If the logic is the same, we probably want to update it together in future, so producing duplicate code doesn't sound good?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes invalid IL generated for closures and recursive bindings.
VerificationExceptionAlso reorders let-rec bindings so lambda closures are allocated before non-lambda values that reference them, avoiding null dereferences at runtime.