WIP :: Bugfix :: Fix codegen runtime crashes: TypeLoadException, InvalidProgramException, stack corruption#19338
Draft
WIP :: Bugfix :: Fix codegen runtime crashes: TypeLoadException, InvalidProgramException, stack corruption#19338
Conversation
Contributor
✅ No release notes required |
T-Gro
force-pushed
the
codegen/fix-runtime-crashes
branch
4 times, most recently
from
68e48f0 to
3616853
Compare
…k corruption Fix 6 codegen bugs that cause hard crashes or invalid IL: - #11132: voidptr delegate TypeLoadException - #13447: tail. + localloc stack corruption - #14492: inline constraints TypeLoadException in Release - #14508: nativeptr in interfaces TypeLoadException - #18319: literal upcast missing box instruction - #18956: decimal literal InvalidProgramException in Debug Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
codegen/fix-runtime-crashes
branch
from
3616853 to
9549f87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes runtime exceptions caused by incorrect IL emitted for valid F# programs.
voidptrin delegate generic args replaced withnativeintin closure encodingNativePtr.stackalloc/locallocSpecialize<>closure methodsnativeptrin interfaces leads to runtime errors #14508 — samevoidptrfix also covers interface instantiationsboxinstruction emitted for literal upcasts (including default parameter values)System.InvalidProgramExceptionfor debug builds #18956 —boxinstruction emitted for decimal literals in debug builds