Skip to content

[MEDI] Remove default storage names from IngestionChunkVectorRecord#7426

Open
Copilot wants to merge 3 commits intodata-ingestion-preview2from
copilot/remove-default-storage-names
Open

[MEDI] Remove default storage names from IngestionChunkVectorRecord#7426
Copilot wants to merge 3 commits intodata-ingestion-preview2from
copilot/remove-default-storage-names

Conversation

Copy link
Contributor

Copilot AI commented Mar 25, 2026

  • Remove EmbeddingStorageName const from VectorStoreExtensions.cs
  • Remove StorageName = EmbeddingStorageName from VectorStoreVectorProperty in GetIngestionRecordCollection
  • Remove storage name constants and StorageName from all attributes in IngestionChunkVectorRecord.cs
  • Update template file IngestedChunk.cs to remove StorageName = EmbeddingStorageName
  • Update README.md example to use [VectorStoreVector(1536)] (simplified, no DistanceFunction)
  • Update test helper TestChunkRecordWithMetadata to remove StorageName = EmbeddingStorageName
  • Update all 5 template snapshot files to remove StorageName = EmbeddingStorageName
  • Build and verify all tests pass
Original prompt

This section details on the original issue you should resolve

<issue_title>[MEDI] Don't provide default storage names</issue_title>
<issue_description>Context: https://github.com/dotnet/extensions/pull/7396/changes#r2974517352

Remove following usages:

internal const string EmbeddingStorageName = "embedding";

/// <summary>
/// The storage name for the <see cref="Embedding"/> property.
/// </summary>
protected const string EmbeddingStorageName = VectorStoreExtensions.EmbeddingStorageName;
private const string KeyStorageName = "key";
private const string DocumentIdStorageName = "documentid";
private const string ContentStorageName = "content";
private const string ContextStorageName = "context";

Don't set the StorageName property for any of the attributes here:

Do KEEP following usages to show it can be customized:

new VectorStoreKeyProperty(nameof(IngestionChunkVectorRecord<>.Key), typeof(Guid)) { StorageName = "custom_key" },
new VectorStoreVectorProperty(nameof(IngestionChunkVectorRecord<>.Embedding), typeof(string), TestEmbeddingGenerator<string>.DimensionCount)
{
StorageName = "custom_embedding",
},
new VectorStoreDataProperty(nameof(IngestionChunkVectorRecord<>.Content), typeof(string)) { StorageName = "custom_content" },
new VectorStoreDataProperty(nameof(IngestionChunkVectorRecord<>.Context), typeof(string)) { StorageName = "custom_context" },
new VectorStoreDataProperty(nameof(IngestionChunkVectorRecord<>.DocumentId), typeof(string))
{
StorageName = "custom_documentid",
IsIndexed = true,
},

cc @roji</issue_description>

<agent_instructions>Study issue description, ensure the repo builds and tests are green after your changes. Don't forget to update template files as well (sample)</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Microsoft Reviewers: Open in CodeFlow

Copilot AI changed the title [WIP] Remove default storage names in data ingestion [MEDI] Remove default storage names from IngestionChunkVectorRecord Mar 25, 2026
Copilot AI requested a review from adamsitnik March 25, 2026 17:00
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot address my feedback and see what we needed to do in #7396 for file in src/ProjectTemplates/Microsoft.Extensions.AI.Templates/* in order to ensure we don't break template tests. Then do the corresponding changes here.

Copy link
Contributor Author

Copilot AI commented Mar 25, 2026

@copilot address my feedback and see what we needed to do in #7396 for file in src/ProjectTemplates/Microsoft.Extensions.AI.Templates/* in order to ensure we...

Done in 5c7335d — updated all 5 IngestedChunk.cs snapshot files under test/ProjectTemplates/Microsoft.Extensions.AI.Templates.IntegrationTests/Snapshots/ to remove StorageName = EmbeddingStorageName, matching the template source change.

Copilot AI requested a review from adamsitnik March 25, 2026 17:16
@adamsitnik adamsitnik marked this pull request as ready for review March 25, 2026 17:30
@adamsitnik adamsitnik requested a review from a team as a code owner March 25, 2026 17:30
@adamsitnik adamsitnik added this to the Data Ingestion Preview 2 milestone Mar 25, 2026
@adamsitnik adamsitnik requested a review from roji March 25, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants