[MEDI] Use MEVD AutoGenerated Guid key feature; update MEVD/SK to latest versions by Copilot · Pull Request #7423 · dotnet/extensions

Copilot · 2026-03-23T11:12:08Z

VectorStoreWriter was manually assigning Key = Guid.NewGuid() on each record before upsert. MEVD 10.1.0 added IsAutoGenerated support on key properties, making this unnecessary.

Changes

VectorStoreWriter.cs: Remove manual Key = Guid.NewGuid() assignment
VectorStoreExtensions.cs: Add VectorStoreKeyProperty with IsAutoGenerated = true to the GetIngestionRecordCollection collection definition — the SK connector now auto-generates the Guid on upsert
VectorStoreWriterTests.cs: Add IsAutoGenerated = true to the key property in the custom-definition test so key generation still works for user-supplied schemas

Note: VectorStoreKeyAttribute.IsAutoGenerated is bool? and therefore not usable as a C# named attribute argument. Auto-generation is configured via VectorStoreKeyProperty in the VectorStoreCollectionDefinition instead.

Dependency updates

Property	Old	New
`MicrosoftExtensionsVectorDataAbstractionsVersion`	`9.7.0`	`10.1.0`
`MicrosoftSemanticKernelConnectorsVersion`	`1.67.0-preview`	`1.74.0-preview`
SK connector versions in `ProjectTemplates.props`	`1.67.1-preview`	`1.74.0-preview`

NuGet.config adds nuget.org as a source scoped exclusively to Microsoft.SemanticKernel.* packages because 1.74.0-preview is not yet mirrored to the internal dotnet-public feed.

Original prompt

This section details on the original issue you should resolve

<issue_title>[MEDI] Use the AutoGenerated Guid key feature added recently by MEVD</issue_title>
<issue_description>We don't need to do this anymore:

extensions/src/Libraries/Microsoft.Extensions.DataIngestion/Writers/VectorStoreWriter.cs

Line 81 in 8b00e5b

var key = Guid.NewGuid();

cc @roji</issue_description>

<agent_instructions>1. Remove the need of setting the key here
2. Run all tests from the test/Libraries/Microsoft.Extensions.DataIngestion.Tests/Microsoft.Extensions.DataIngestion.Tests.csproj project, if any test fails, you need to update Microsoft.Extensions.VectorData (MEVD) version to latest
3. The MEVD version needs to be updated here and here
4. Update to latest version (10.1.0 for MicrosoftExtensionsVectorDataAbstractionsVersion) and 1.74.0-preview for MicrosoftSemanticKernelConnectorsVersion)
5. Ensure all tests are passing before sending a PR</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes [MEDI] Use the AutoGenerated Guid key feature added recently by MEVD #7410

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Microsoft Reviewers: Open in CodeFlow

…tedChunkRecord base type Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…toreWriter refactoring Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…ion property names Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…al, throw in SetMetadata, make consts protected, remove JSON attributes Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…oc reference, remove JsonPropertyName, add custom schema test Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

… custom storage names in test Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

… for consistency Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>

Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…ot IngestedChunk.cs files Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…n, move SetMetadata to non-sealed VectorStoreWriter Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

…n with provided dimension count

…ied overload, fix typo, update README - Renamed IngestedChunkRecord<TChunk> to IngestionChunkVectorRecord<TChunk> across all source, test, template, and snapshot files - Fixed typo 'additiveDefintion' -> 'additiveDefinition' in VectorStoreExtensions.cs - Added simplified non-generic GetIngestionRecordCollection overload for the common IngestionChunkVectorRecord<string> case - Added XML remarks to generic GetIngestionRecordCollection method documenting usage patterns (simple, custom metadata, custom schema) - Extended README.md with code samples for basic usage, custom metadata, and custom collection schema Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/extensions/sessions/4dce2c93-8680-43ae-a663-bcd22316c92b

… to latest Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/extensions/sessions/45713a5e-1067-42e6-a6e2-a172b8bef7ee

adamsitnik

@copilot address my feedback

adamsitnik · 2026-03-23T11:39:13Z

src/Libraries/Microsoft.Extensions.DataIngestion/Writers/VectorStoreExtensions.cs

+                new VectorStoreKeyProperty(nameof(IngestionChunkVectorRecord<>.Key), typeof(Guid))
+                {
+                    IsAutoGenerated = true,
+                },
+


We don't need it here, it should be set using the attribute here

Suggested change

new VectorStoreKeyProperty(nameof(IngestionChunkVectorRecord<>.Key), typeof(Guid))

{

IsAutoGenerated = true,

},

Unfortunately VectorStoreKeyAttribute.IsAutoGenerated is of type Nullable<bool> in MEVD 10.1.0, which cannot be used as a C# named attribute argument — the compiler rejects it with CS0655: 'IsAutoGenerated' is not a valid named attribute argument because it is not a valid attribute parameter type.

Because of this constraint, IsAutoGenerated = true must be set via VectorStoreKeyProperty in the collection definition (the current approach). Once MEVD changes IsAutoGenerated from bool? to bool, we can move this to the attribute.

I've provided a fix in the SK repo (microsoft/semantic-kernel#13698). For now, let's stick with what we have here.

NuGet.config

Copilot · 2026-03-23T11:56:25Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/microsoft/semantic-kernel/git/trees/main
- Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…pilot/remove-key-setting-requirement # Conflicts: # src/Libraries/Microsoft.Extensions.DataIngestion/README.md # src/Libraries/Microsoft.Extensions.DataIngestion/Writers/IngestionChunkVectorRecord.cs # src/Libraries/Microsoft.Extensions.DataIngestion/Writers/VectorStoreExtensions.cs # src/Libraries/Microsoft.Extensions.DataIngestion/Writers/VectorStoreWriter.cs # test/Libraries/Microsoft.Extensions.DataIngestion.Tests/Writers/VectorStoreWriterTests.cs

roji · 2026-03-25T17:03:50Z

src/Libraries/Microsoft.Extensions.DataIngestion/Writers/VectorStoreExtensions.cs

            {
+                new VectorStoreKeyProperty(nameof(IngestionChunkVectorRecord<>.Key), typeof(Guid))
+                {
+                    IsAutoGenerated = true,


Technically this should not be needed, as all providers are expected to support Guid auto-generation. But it's a good idea to have it (a) for clarity, and (b) in case some provider out there decides to not support this, setting to true here should cause it to throw.

Copilot AI and others added 17 commits March 14, 2026 20:50

Initial plan

ea56d33

Refactor VectorStoreWriter to accept VectorStoreCollection, add Inges…

581bce0

…tedChunkRecord base type Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Update all test files, snapshot files, and template files for VectorS…

727bcd5

…toreWriter refactoring Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Fix warnings and test failures - correct VectorStoreCollectionDefinit…

e48fa9d

…ion property names Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Address code review feedback - fix error message wording

e9aa7fe

Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Address reviewer feedback: remove TKey generic, make properties virtu…

56fa7ad

…al, throw in SetMetadata, make consts protected, remove JSON attributes Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Address second round of reviewer feedback: make consts private, fix d…

c3c57e0

…oc reference, remove JsonPropertyName, add custom schema test Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Rename EmbeddingPropertyName to EmbeddingStorageName (protected), use…

b3153bf

… custom storage names in test Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Rename private storage name consts from *PropertyName to *StorageName…

550781c

… for consistency Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Apply suggestions from code review

def5e6a

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>

Remove unnecessary 'using System' from TestChunkRecordWithMetadata.cs

64af799

Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Remove stale using System.Text.Json.Serialization from all 5 snapsh…

81f4817

…ot IngestedChunk.cs files Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Rename CreateCollectionDefinition to CreateDefaultCollectionDefinitio…

f20bb41

…n, move SetMetadata to non-sealed VectorStoreWriter Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

provide a VectorStore extension method to create VectorStoreCollectio…

4558e6c

…n with provided dimension count

Use explicit type names instead of var in README.md code samples

f34bce2

Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/extensions/sessions/4dce2c93-8680-43ae-a663-bcd22316c92b

Initial plan

7548426

Copilot AI assigned Copilot and adamsitnik Mar 23, 2026

Copilot started work on behalf of adamsitnik March 23, 2026 11:12 View session

adamsitnik added the area-data-ingestion label Mar 23, 2026

adamsitnik added this to the Data Ingestion Preview 2 milestone Mar 23, 2026

Use AutoGenerated Guid key feature from MEVD, update MEVD/SK versions…

dd79c0e

… to latest Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/extensions/sessions/45713a5e-1067-42e6-a6e2-a172b8bef7ee

Copilot AI changed the title ~~[WIP] Remove key setting requirement for auto-generated Guid feature~~ [MEDI] Use MEVD AutoGenerated Guid key feature; update MEVD/SK to latest versions Mar 23, 2026

Copilot AI requested a review from adamsitnik March 23, 2026 11:28

Copilot finished work on behalf of adamsitnik March 23, 2026 11:28

adamsitnik reviewed Mar 23, 2026

View reviewed changes

Copilot started work on behalf of adamsitnik March 23, 2026 11:41 View session

Copilot AI requested a review from adamsitnik March 23, 2026 11:56

Copilot finished work on behalf of adamsitnik March 23, 2026 11:56

address my own feedback

6621dc5

Base automatically changed from copilot/fix-vectorstorewriter-injection to data-ingestion-preview2 March 25, 2026 16:12

adamsitnik marked this pull request as ready for review March 25, 2026 16:28

adamsitnik requested a review from a team as a code owner March 25, 2026 16:28

roji approved these changes Mar 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MEDI] Use MEVD AutoGenerated Guid key feature; update MEVD/SK to latest versions#7423

[MEDI] Use MEVD AutoGenerated Guid key feature; update MEVD/SK to latest versions#7423
Copilot wants to merge 20 commits intodata-ingestion-preview2from
copilot/remove-key-setting-requirement

Copilot AI commented Mar 23, 2026 •

edited

Loading

Uh oh!

adamsitnik left a comment

Uh oh!

adamsitnik Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

adamsitnik Mar 25, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 23, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

roji Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Dependency updates

Comments on the Issue (you are @copilot in this section)

Microsoft Reviewers: Open in CodeFlow

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

adamsitnik Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

adamsitnik Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 23, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

roji Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 23, 2026 •

edited

Loading