Fix OpenAI responses streaming to preserve encrypted reasoning content#7266
Open
stephentoub wants to merge 2 commits intodotnet:mainfrom
Open
Fix OpenAI responses streaming to preserve encrypted reasoning content#7266stephentoub wants to merge 2 commits intodotnet:mainfrom
stephentoub wants to merge 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in OpenAI streaming responses where encrypted reasoning content was being lost during the streaming process. The fix ensures that when a ReasoningResponseItem contains encrypted content in the output_item.done event, that encrypted content is properly preserved and coalesced with the streamed text deltas, enabling correct roundtripping of encrypted reasoning data.
Changes:
- Added streaming support for encrypted reasoning content by yielding a
TextReasoningContentwith onlyProtectedDatawhen encrypted content is present - Added comprehensive unit test for streaming encrypted content preservation
- Added integration tests for roundtripping encrypted content in both streaming and non-streaming scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponsesChatClient.cs | Added new case in streaming handler to yield encrypted content from ReasoningResponseItem when present, ensuring it gets coalesced with text deltas |
| test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIResponseClientTests.cs | Added unit test verifying that encrypted content is preserved through streaming and coalescing |
| test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIResponseClientIntegrationTests.cs | Added integration tests for both streaming and non-streaming roundtrip scenarios with encrypted content |
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponsesChatClient.cs
Outdated
Show resolved
Hide resolved
…atClient.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow