introduce support for the Gauge metric type#7203
Draft
Conversation
…rt' into dbohdanov/source-gen-gauge-support
| return tagConfigs; | ||
| } | ||
|
|
||
| if (typeSymbol.OriginalDefinition.SpecialType == SpecialType.System_Nullable_T) |
Contributor
There was a problem hiding this comment.
Why is this change needed in this PR?
Contributor
Author
There was a problem hiding this comment.
It's not directly related to Gauge, but it's a bug fix since some of the types could've slipped through validation. int? has specialType=None initially and then it gets unwrapped at specialType = typeSymbol.OriginalDefinition.SpecialType which results in System_Nullable_T instead of the real type. That behavior makes the logic inconsistent, since int?, double?, DateTime? would pass the validation. These changes detect it early and return before unwrapping happens
| Assembly.GetAssembly(typeof(CounterAttribute))!, | ||
| Assembly.GetAssembly(typeof(HistogramAttribute))!, | ||
| Assembly.GetAssembly(typeof(CounterAttribute<>))!, | ||
| Assembly.GetAssembly(typeof(HistogramAttribute<>))!, |
Contributor
There was a problem hiding this comment.
Can we add Gauge and Gauge<T> here?
|
|
||
| [Fact] | ||
| public async Task GaugeNotSupported() | ||
| public async Task GaugeIsSDocumented() |
Contributor
There was a problem hiding this comment.
Suggested change
| public async Task GaugeIsSDocumented() | |
| public async Task GaugeIsDocumented() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow