add CommTagAttribute for metric code generator#6244
add CommTagAttribute for metric code generator#6244BowenYang666 wants to merge 3 commits intodotnet:mainfrom
Conversation
@dotnet-policy-service agree company="Microsoft" |
|
This seems like a cool idea. Did you write up an API proposal for this? Since it's a new feature we might want to discuss it there, so that we don't end up having to change things later. |
| /// </example> | ||
| [AttributeUsage(AttributeTargets.Class, AllowMultiple = true)] | ||
| [Conditional("CODE_GENERATION_ATTRIBUTES")] | ||
| [Experimental("EXPERIMENTAL_COMMON_TAG_ATTRIBUTE")] |
There was a problem hiding this comment.
Should use the well-defined experiment IDs
| [Experimental("EXPERIMENTAL_COMMON_TAG_ATTRIBUTE")] | |
| [Experimental(diagnosticId: DiagnosticIds.Experiments.Telemetry, UrlFormat = DiagnosticIds.UrlFormat)] |
Thanks Darius. I have created a new feature proposal here: |
|
@BowenYang666 - could you put together a proper API proposal, please? |
|
I don't know how I missed your comment @evgenyfedorov2, but yes I will work with @BowenYang666 to push this through the process. |
Support common tag and value for the same group of metrics
Microsoft Reviewers: Open in CodeFlow