Fix incorrect comment label in partial property snippet#53652
Open
Fix incorrect comment label in partial property snippet#53652
Conversation
Open
…ng declaration Agent-Logs-Url: https://github.com/dotnet/docs/sessions/41c6c349-354f-4a06-8391-a7522dfa30a4 Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix comment for implementing declaration in property bag example
Fix incorrect comment label in partial property snippet
May 6, 2026
BillWagner
approved these changes
May 6, 2026
Member
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM and is ready for final review.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a mislabeled comment in the C# “partial property” (<FieldProperty>) snippet so that the two partial declarations are correctly described as defining vs implementing declarations, aligning the snippet’s terminology with the associated article.
Changes:
- Updated the comment in the second partial
PropertyBagdeclaration from// Defining declarationto// Implementing declaration.
gewarren
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FieldPropertycode snippet had duplicate// Defining declarationcomments, where the second occurrence should have been// Implementing declaration.Program.cs(line 182): Changed// Defining declaration→// Implementing declarationon the class containing the property implementation (get => field; set;)Labels now match the article's terminology ("defining and implementing member declaration").