Add Compression best practices guide#52968
Draft
alinpahontu2912 wants to merge 2 commits intodotnet:mainfrom
Draft
Add Compression best practices guide#52968alinpahontu2912 wants to merge 2 commits intodotnet:mainfrom
alinpahontu2912 wants to merge 2 commits intodotnet:mainfrom
Conversation
rzikm
reviewed
Apr 10, 2026
docs/standard/io/snippets/zip-tar-best-practices/csharp/Program.cs
Outdated
Show resolved
Hide resolved
docs/standard/io/snippets/zip-tar-best-practices/csharp/Program.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+134
to
+136
| // ZIP uses a convention where directory entries have names ending in '/'. | ||
| // Path.GetFileName returns empty for these, so we use that to | ||
| // distinguish directories from files. |
Member
There was a problem hiding this comment.
Is this coming from the specification?
Member
Author
There was a problem hiding this comment.
I will rephrase it, but this is how we do it https://github.com/dotnet/runtime/blob/main/src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchiveEntry.cs#L130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a guide explaining how to best work with Zip and Tar archives in .NET.
Internal previews