Fix Orleans custom grain storage docs: replace removed AddSingletonNamedService with AddKeyedSingleton#52135
Open
Fix Orleans custom grain storage docs: replace removed AddSingletonNamedService with AddKeyedSingleton#52135
AddSingletonNamedService with AddKeyedSingleton#52135Conversation
…AddKeyedSingleton Co-authored-by: meaghanlewis <10103121+meaghanlewis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update documentation for Grain File Storage example in Orleans 10
Fix Orleans custom grain storage docs: replace removed Mar 10, 2026
AddSingletonNamedService with AddKeyedSingleton
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the custom grain storage tutorial text to align with Orleans 9+ by removing references to removed Orleans-internal named-service DI APIs and describing the current keyed DI approach.
Changes:
- Updated frontmatter metadata (
ms.date, addedai-usage). - Replaced prose referencing
AddSingletonNamedService/GetRequiredServiceByNamewith.NETkeyed DI (AddKeyedSingleton). - Removed the inline “old (broken)” code block describing the removed Orleans API.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eton Co-authored-by: meaghanlewis <10103121+meaghanlewis@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
custom-grain-storage.mdtext to replaceAddSingletonNamedServicereferences withAddKeyedSingletonAddSingletonNamedServiceAPIKeyedServiceExtensions.AddKeyedSingleton→ServiceCollectionServiceExtensions.AddKeyedSingletonms.datefrontmatter and addai-usage: ai-assistedOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Internal previews