Skip to content

Fix Orleans custom grain storage docs: replace removed AddSingletonNamedService with AddKeyedSingleton#52135

Open
Copilot wants to merge 4 commits intomainfrom
copilot/revise-documentation-orleans-10
Open

Fix Orleans custom grain storage docs: replace removed AddSingletonNamedService with AddKeyedSingleton#52135
Copilot wants to merge 4 commits intomainfrom
copilot/revise-documentation-orleans-10

Conversation

Copy link
Contributor

Copilot AI commented Mar 10, 2026

  • Update custom-grain-storage.md text to replace AddSingletonNamedService references with AddKeyedSingleton
  • Remove the outdated inline code block showing the old AddSingletonNamedService API
  • Fix broken xref: change KeyedServiceExtensions.AddKeyedSingletonServiceCollectionServiceExtensions.AddKeyedSingleton
  • Update ms.date frontmatter and add ai-usage: ai-assisted
Original prompt

This section details on the original issue you should resolve

<issue_title>Documentation not revised according to reported problem</issue_title>
<issue_description>### Type of issue

Code doesn't work

Description

See:
Is the Grain File Storage Example Still Valid in Orleans 9?
And now also for version 10

Page URL

https://learn.microsoft.com/en-us/dotnet/orleans/tutorials-and-samples/custom-grain-storage?pivots=orleans-10-0

Content source URL

https://github.com/dotnet/docs/blob/main/docs/orleans/tutorials-and-samples/custom-grain-storage.md

Document Version Independent Id

5f0db119-a02e-55fc-ac0f-a04ad2cfc2a1

Platform Id

bc76f793-9bac-a2a8-96e7-c600f8e1885e

Article author

@meaghanlewis

Metadata

  • ID: 494f78b0-7801-5554-643c-bfda075ce7f4
  • PlatformId: bc76f793-9bac-a2a8-96e7-c600f8e1885e
  • Service: dotnet-orleans

Related Issues</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Internal previews

📄 File 🔗 Preview link
docs/orleans/tutorials-and-samples/custom-grain-storage.md docs/orleans/tutorials-and-samples/custom-grain-storage

…AddKeyedSingleton

Co-authored-by: meaghanlewis <10103121+meaghanlewis@users.noreply.github.com>
Copilot AI changed the title [WIP] Update documentation for Grain File Storage example in Orleans 10 Fix Orleans custom grain storage docs: replace removed AddSingletonNamedService with AddKeyedSingleton Mar 10, 2026
@meaghanlewis meaghanlewis marked this pull request as ready for review March 10, 2026 18:25
Copilot AI review requested due to automatic review settings March 10, 2026 18:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the custom grain storage tutorial text to align with Orleans 9+ by removing references to removed Orleans-internal named-service DI APIs and describing the current keyed DI approach.

Changes:

  • Updated frontmatter metadata (ms.date, added ai-usage).
  • Replaced prose referencing AddSingletonNamedService / GetRequiredServiceByName with .NET keyed DI (AddKeyedSingleton).
  • Removed the inline “old (broken)” code block describing the removed Orleans API.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eton

Co-authored-by: meaghanlewis <10103121+meaghanlewis@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 10, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • learn.microsoft.com
    • Triggering command: /usr/bin/curl curl -s REDACTED$skip=0&amp;$top=5 (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation not revised according to reported problem

3 participants