Improve StringBuilder interop guidance: warn about allocations, promote ArrayPool#52133
Draft
Improve StringBuilder interop guidance: warn about allocations, promote ArrayPool#52133
Conversation
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update best practices related to StringBuilder usage
Improve StringBuilder interop guidance: warn about allocations, promote ArrayPool
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Fixed-length string buffers" section presented
StringBuilderas a co-equal alternative tochar[]/ArrayPool, with only a mild[!NOTE]about performance. This conflicts with the native interop best practices page, which explicitly recommends avoidingStringBuilderparameters due to excessive allocations.Changes
ArrayPool<char>as the explicitly recommended approach — updated the intro sentence to call it out as suchStringBuilder— changed "Another solution is..." to "You might also consider..." to signal it's secondary[!NOTE]→[!CAUTION]with a detailed breakdown of whyStringBuilderis costly:ToString())StringBuildersaves only one allocation vs.ArrayPool<char>which reduces it to justToString()Avoid StringBuilder parameters for P/Invokes) alongside the existing best-practices linkOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.
Internal previews