Improve sample: safer argument parsing and clearer delay#52114
Open
ivanPeshterskii wants to merge 1 commit intodotnet:mainfrom
Open
Improve sample: safer argument parsing and clearer delay#52114ivanPeshterskii wants to merge 1 commit intodotnet:mainfrom
ivanPeshterskii wants to merge 1 commit intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the readability and robustness of the code sample.
Changes made
Convert.ToInt32withint.TryParseto prevent exceptions when invalid input is provided.args.Length is not 0toargs.Length > 0for better clarity.TimeSpan.FromMilliseconds(1_000)withTimeSpan.FromSeconds(1)to improve readability.These changes make the sample safer and easier to understand, especially for developers who are new to C#.
Motivation
The previous version could throw an exception if a non-numeric argument was passed. Using
int.TryParseensures the example behaves more safely and demonstrates a recommended pattern for parsing user input.