Skip to content

Parallelize GetAllImageDigestsFromRegistryAsync #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lbussell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Parallelize GetAllImageDigestsFromRegistryAsync #1909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ImageBuilder/Commands/GenerateEolAnnotationDataCommandBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ protected async Task<IEnumerable<EolDigestData>> GetAllImageDigestsFromRegistryA
.Where(repo => repoNameFilter is null || repoNameFilter(repo));

ConcurrentBag<(string Digest, string? Tag)> digests = [];
await foreach (string repositoryName in repositoryNames)
await Parallel.ForEachAsync(repositoryNames, async (repositoryName, outerCT) =>
{
IAcrContentClient contentClient =
_acrContentClientFactory.Create(
Expand All @@ -83,7 +83,7 @@ protected async Task<IEnumerable<EolDigestData>> GetAllImageDigestsFromRegistryA

ContainerRepository repo = acrClient.GetRepository(repositoryName);
IAsyncEnumerable<ArtifactManifestProperties> manifests = repo.GetAllManifestPropertiesAsync();
await foreach (ArtifactManifestProperties manifestProps in manifests)
await Parallel.ForEachAsync(manifests, outerCT, async (manifestProps, innerCT) =>
{
ManifestQueryResult manifestResult = await contentClient.GetManifestAsync(manifestProps.Digest);

Expand All @@ -99,8 +99,8 @@ protected async Task<IEnumerable<EolDigestData>> GetAllImageDigestsFromRegistryA
digest: manifestProps.Digest);
digests.Add((imageName, GetLongestTag(manifestProps.Tags)));
}
}
}
});
});

return digests
.Select(val => new EolDigestData(val.Digest) { Tag = val.Tag });
Expand Down
Loading