Skip to content

Refactor conditional logic for handling application endpoints in GraphMinimalPermissionsGuidancePlugin. Closes #1605 #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waldekmastykarz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor conditional logic for handling application endpoints in GraphMinimalPermissionsGuidancePlugin. Closes #1605 #1606

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1379e42
Refactor conditional logic for handling application endpoints in Grap…
waldekmastykarz Mar 28, 2026
ad16645
Merge branch 'main' into fix/1605-app-permissions-missing-endpoints
waldekmastykarz Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions DevProxy.Plugins/Reporting/GraphMinimalPermissionsGuidancePlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,22 +141,20 @@ public override async Task AfterRecordingStopAsync(RecordingArgs e, Cancellation
}
else
{
// skip empty roles which are returned in case we couldn't get permissions information
//
// application permissions are always the same because they come from app reg
// so we can just use the first request that has them
if (permissions.Any() && !rolesToEvaluate.Any())
{
rolesToEvaluate = permissions;
}

if (ProxyUtils.IsGraphBatchUrl(uri))
{
applicationEndpoints.AddRange(requestsFromBatch);
}
else
{
applicationEndpoints.Add(methodAndUrl);
}
if (ProxyUtils.IsGraphBatchUrl(uri))
{
applicationEndpoints.AddRange(requestsFromBatch);
}
else
{
applicationEndpoints.Add(methodAndUrl);
}
}
}
Expand Down
Loading