Modify local development validation to skip on PRs#66133
Modify local development validation to skip on PRs#66133BrennanConroy wants to merge 2 commits intomainfrom
Conversation
github-actions
bot
added
the
area-infrastructure
There was a problem hiding this comment.
Pull request overview
Updates the public CI pipeline to avoid running the “local development validation” job on Pull Request builds, reducing PR validation cost/time while keeping the job for non-PR runs.
Changes:
- Wrap the
Local_Windowslocal development validation job in a PR-skip condition based onBuild.Reason.
| path: artifacts/log/ | ||
| publishOnError: true | ||
| includeForks: true | ||
| # Local development validation (skip on PRs) |
There was a problem hiding this comment.
What's the motivation for this? This job was added to ensure changes in PRs don't break local dev scenarios
There was a problem hiding this comment.
I thought this had been talked about but can't find a chat history now. Maybe it was over a call.
How many times has this actually failed because someone broke local dev? It seems like it's just an extra step that slows down PR builds with very little benefit.
There was a problem hiding this comment.
@javiercn and @ilonatommy might have more insight on that - I think this was Javier and Mackinnon's brainchild & was motivated by uncaught regressions in the local dev experience
There was a problem hiding this comment.
I don't have historic knowledge but the repo search confirms that Mackinnon added the template tests run to see if the generated projects build/publish/run after we broke local template development #56237. Afterwards, we expanded the job to run the full dev pipeline for templates: #60016.
We saved #60504 in backlog to make this validation cheaper, I believe we should follow its suggestions before removing it from running.
dotnet-policy-service
bot
added
the
pending-ci-rerun
No description provided.