Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Buffers;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Components.Discovery;
using Microsoft.AspNetCore.Components.Endpoints.Infrastructure;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Routing;
using Microsoft.AspNetCore.Routing.Patterns;
using Microsoft.AspNetCore.StaticAssets.Infrastructure;
using Microsoft.AspNetCore.StaticFiles;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Primitives;
using static Microsoft.AspNetCore.Internal.LinkerFlags;

Expand Down Expand Up @@ -184,6 +188,7 @@ private void UpdateEndpoints()
private void AddBlazorWebEndpoints(List<Endpoint> endpoints)
{
List<EndpointBuilder> blazorWebEndpoints = [
..GetBlazorWebJsEndpoint(_endpointRouteBuilder),
OpaqueRedirection.GetBlazorOpaqueRedirectionEndpoint()];

foreach (var endpoint in blazorWebEndpoints)
Expand All @@ -202,6 +207,50 @@ private void AddBlazorWebEndpoints(List<Endpoint> endpoints)
}
}

private static IEnumerable<EndpointBuilder> GetBlazorWebJsEndpoint(IEndpointRouteBuilder endpoints)
{
// TODO: Is this how we want to check?
if (StaticAssetsEndpointDataSourceHelper.HasStaticAssetsDataSource(endpoints))
{
return [];
}

var app = endpoints.CreateApplicationBuilder();

var webHostEnvironment = endpoints.ServiceProvider.GetRequiredService<IWebHostEnvironment>();

var options = new StaticFileOptions
{
FileProvider = webHostEnvironment.WebRootFileProvider,
OnPrepareResponse = CacheHeaderSettings.SetCacheHeaders
};

app.Use(next => context =>
{
// Set endpoint to null so the static files middleware will handle the request.
context.SetEndpoint(null);

return next(context);
});

app.UseStaticFiles(options);

var requestDelegate = app.Build();

var blazorWebJsBuilder = new RouteEndpointBuilder(
requestDelegate,
RoutePatternFactory.Parse("/_framework/blazor.web.js"),
int.MinValue)
{
DisplayName = "Blazor web static files"
};

var allowedHttpMethods = new HttpMethodMetadata([HttpMethods.Get, HttpMethods.Head]);
blazorWebJsBuilder.Metadata.Add(allowedHttpMethods);

return [blazorWebJsBuilder];
}

public override IChangeToken GetChangeToken()
{
Initialize();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,18 @@ public sealed class ComponentEndpointConventionBuilder : IHubEndpointConventionB
private readonly IEndpointConventionBuilder _hubEndpoint;
private readonly IEndpointConventionBuilder _disconnectEndpoint;
private readonly IEndpointConventionBuilder _jsInitializersEndpoint;
private readonly IEndpointConventionBuilder? _blazorEndpoint;

internal ComponentEndpointConventionBuilder(
IEndpointConventionBuilder hubEndpoint,
IEndpointConventionBuilder disconnectEndpoint,
IEndpointConventionBuilder jsInitializersEndpoint)
IEndpointConventionBuilder jsInitializersEndpoint,
IEndpointConventionBuilder? blazorEndpoint)
{
_hubEndpoint = hubEndpoint;
_disconnectEndpoint = disconnectEndpoint;
_jsInitializersEndpoint = jsInitializersEndpoint;
_blazorEndpoint = blazorEndpoint;
}

/// <summary>
Expand All @@ -31,6 +34,7 @@ public void Add(Action<EndpointBuilder> convention)
_hubEndpoint.Add(convention);
_disconnectEndpoint.Add(convention);
_jsInitializersEndpoint.Add(convention);
_blazorEndpoint?.Add(convention);
}

/// <inheritdoc/>
Expand All @@ -39,5 +43,6 @@ public void Finally(Action<EndpointBuilder> finalConvention)
_hubEndpoint.Finally(finalConvention);
_disconnectEndpoint.Finally(finalConvention);
_jsInitializersEndpoint.Finally(finalConvention);
_blazorEndpoint?.Finally(finalConvention);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@
// The .NET Foundation licenses this file to you under the MIT license.

using Microsoft.AspNetCore.Components.Server;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Http.Connections;
using Microsoft.AspNetCore.Routing;
using Microsoft.AspNetCore.SignalR;
using Microsoft.AspNetCore.StaticFiles;
using Microsoft.Extensions.DependencyInjection;

namespace Microsoft.AspNetCore.Builder;

Expand Down Expand Up @@ -85,6 +89,42 @@
endpoints.CreateApplicationBuilder().UseMiddleware<CircuitJavaScriptInitializationMiddleware>().Build())
.WithDisplayName("Blazor initializers");

return new ComponentEndpointConventionBuilder(hubEndpoint, disconnectEndpoint, jsInitializersEndpoint);
var blazorEndpoint = GetBlazorEndpoint(endpoints);

return new ComponentEndpointConventionBuilder(hubEndpoint, disconnectEndpoint, jsInitializersEndpoint, blazorEndpoint);
}

private static IEndpointConventionBuilder? GetBlazorEndpoint(IEndpointRouteBuilder endpoints)
{
// TODO: Is this how we want to check? If so, do we want to add the necessary reference to Microsoft.AspNetCore.StaticAssets?
if (false /*StaticAssetsEndpointDataSourceHelper.HasStaticAssetsDataSource(endpoints)*/)
{
return null;

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Source-Build (Managed))

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux x64)

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: Ubuntu x64)

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS arm64)

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS x64)

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: macOS)

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: macOS)

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected

Check failure on line 102 in src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs#L102

src/Components/Server/src/Builder/ComponentEndpointRouteBuilderExtensions.cs(102,13): error CS0162: (NETCORE_ENGINEERING_TELEMETRY=Build) Unreachable code detected
}

var webHostEnvironment = endpoints.ServiceProvider.GetRequiredService<IWebHostEnvironment>();

var options = new StaticFileOptions
{
FileProvider = webHostEnvironment.WebRootFileProvider,
OnPrepareResponse = CacheHeaderSettings.SetCacheHeaders
};

var app = endpoints.CreateApplicationBuilder();
app.Use(next => context =>
{
// Set endpoint to null so the static files middleware will handle the request.
context.SetEndpoint(null);

return next(context);
});
app.UseStaticFiles(options);

var blazorEndpoint = endpoints.Map("/_framework/blazor.server.js", app.Build())
.WithDisplayName("Blazor static files");

blazorEndpoint.Add((builder) => ((RouteEndpointBuilder)builder).Order = int.MinValue);

return blazorEndpoint;
}
}
Loading