Skip to content

Add arm64 support for ANCMDepProviderKey#65978

Open
wtgodbe wants to merge 4 commits intomainfrom
wtgodbe/depkeyarm
Open

Add arm64 support for ANCMDepProviderKey#65978
wtgodbe wants to merge 4 commits intomainfrom
wtgodbe/depkeyarm

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented Mar 25, 2026

Fixes #65953

@wtgodbe wtgodbe requested a review from a team as a code owner March 25, 2026 17:34
Copilot AI review requested due to automatic review settings March 25, 2026 17:34
@github-actions github-actions bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Mar 25, 2026
@wtgodbe wtgodbe requested a review from joeloff March 25, 2026 17:35
Copilot AI reviewed Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #65953 by ensuring ANCMV2’s Windows installer dependency provider key differentiates arm64 installs from x64 installs, preventing incorrect reference counting across architectures.

Changes:

  • Split the ANCMDepProviderKey MSBuild property into distinct x64 and arm64 values (instead of treating all non-x86 as x64).

joeloff
joeloff reviewed Mar 25, 2026
View reviewed changes
src/Installers/Windows/AspNetCoreModule-Setup/ANCMIISExpressV2/AncmIISExpressV2.wixproj Outdated
Comment on lines +24 to +25
<ANCMDepProviderKey Condition="'$(Platform)' == 'x64'">IISExpress_AspNetCore_Module_V2,x64</ANCMDepProviderKey>
<ANCMDepProviderKey Condition="'$(Platform)' == 'arm64'">IISExpress_AspNetCore_Module_V2,arm64</ANCMDepProviderKey>
Copy link
Copy Markdown
Member

@joeloff joeloff Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be simpler if we did <ANCMDepProviderKey>IISExpress_AspNetCore_Module_V2,$(Platform.ToLower())</ANCMDepProviderKey>

@joeloff
Copy link
Copy Markdown
Member

joeloff commented Mar 25, 2026

@wtgodbe will you submit to tactics and look at porting to 8, 9, 10?

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Mar 27, 2026

will you submit to tactics and look at porting to 8, 9, 10?

Yes

This was referenced Mar 28, 2026
Open
Open
Open
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service bot commented Apr 3, 2026

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joeloff joeloff joeloff left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ACNM: Dependency provider use the same key for both arm64 and x64

3 participants

@wtgodbe @joeloff