Draft
Conversation
97a117e to
98ffc86
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the RepoTasks build infrastructure by leveraging MSBuild's Runtime="NET" feature to simplify the project from multi-targeting (.NET Framework and .NET Core) to a single .NET Core target framework. This eliminates conditional logic and .NET Framework-specific code while maintaining all required functionality.
Changes:
- Simplified task assembly loading by using MSBuild's
Runtime="NET"attribute on UsingTask elements - Removed multi-targeting support, consolidating to a single .NET Core target framework
- Eliminated .NET Framework-specific code and dependencies (GetMsiProperty task, MSI-related packages)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/tools/RepoTasks/RepoTasks.tasks | Simplified task loading using Runtime="NET" attribute; removed conditional MSBuildRuntimeType logic and GetMsiProperty task reference |
| eng/tools/RepoTasks/RepoTasks.csproj | Changed from multi-targeting to single TargetFramework; added AppendTargetFrameworkToOutputPath=false; removed .NET Framework-specific dependencies and conditional compilation |
| eng/tools/RepoTasks/GetMsiProperty.cs | Deleted .NET Framework-only MSI property reading task |
| eng/tools/RepoTasks/GenerateTestDevCert.cs | Explicitly qualified base class as Microsoft.Build.Utilities.Task for clarity |
wtgodbe
approved these changes
Jan 29, 2026
Member
Author
|
I forgot to check if any of these tasks are used in a non Microsoft.NET.Sdk project as that's currently not supported. |
Contributor
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{PR title}
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)