Adopt ProblemHttpResult pattern for ProblemDetailsService in TypedResults#65114
Closed
Copilot wants to merge 2 commits intofeature/typed-results-problemdetails-servicefrom
Closed
Adopt ProblemHttpResult pattern for ProblemDetailsService in TypedResults#65114Copilot wants to merge 2 commits intofeature/typed-results-problemdetails-servicefrom
Copilot wants to merge 2 commits intofeature/typed-results-problemdetails-servicefrom
Conversation
5 tasks
Co-authored-by: mikekistler <85643503+mikekistler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on ProblemDetailsService implementation
Adopt ProblemHttpResult pattern for ProblemDetailsService in TypedResults
Jan 18, 2026
Contributor
|
Thanks @copilot, but I'll just make this change myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt ProblemHttpResult pattern for ProblemDetailsService in TypedResults
Standardizes ProblemDetailsService handling across TypedResults to match ProblemHttpResult pattern.
Description
The TypedResults classes (
BadRequest<T>,InternalServerError<T>,Conflict<T>,UnprocessableEntity<T>) used an inconsistent pattern for handlingIProblemDetailsServicecompared toProblemHttpResult.Changed pattern from:
To:
This aligns with the established pattern in
ProblemHttpResult.csand eliminates the early return, making the fallback logic explicit.Files Changed
InternalServerErrorOfT.csBadRequestOfT.csConflictOfT.csUnprocessableEntityOfT.cs✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.