Update to latest templating autoring package to fix CG alert#16830
Update to latest templating autoring package to fix CG alert#16830marcpopMSFT wants to merge 1 commit into
Conversation
|
Looks like this is used in a couple repos: https://github.com/search?q=org%3Adotnet+UsingToolTemplateLocalizer+-repo%3Adotnet%2Fdotnet&type=code We also apparently hit an issue once that caused us to downgrade 9.0.101 to 9.0.100 of that package: #15257 @mmitche @ViktorHofer do you remember anything about this? I also see we're still using a random 10.0.100-preview.4 in both 10.0 and main... |
|
The revert was due to .NET Framework tasks not being able to load the assembly anymore due to binding redirects in msbuild. EDIT: Just saw the branch. Yes, we need to be super careful here. You would want to validate that the .NET Framework task is still loadable by the VS version used in this branch. You could also add an integration test directly here to validate that. |
This was flagged by CG as the -rtm version is considered prerelease and from the version number, it was a random build in September of that year. I'm not sure how to low cost confirm that this is ok and if we wanted to go to 8.0.100 version, I'd be ok with that to. The current version is wrong and I'm not really looking to add a test since this isn't likely to be updated frequently. Is the issue that the repos that use this build using VS and it could break their builds? How do I verify that? |
|
|
I think this is safe. |
I got a CG alert that we were still on the -rtm version of this package from 2023. I found the latest build from May and did an update-dependencies on it. I'm not sure what depends on this package or how to validate that the latest version is compatible with the prior one. There should not be any intentional breaks in the package afaik.