Add CulturedConditionalFactAttribute and CulturedConditionalTheoryAttribute to XUnitV3Extensions

[Copilot]

Adds conditional variants of CulturedFactAttribute and CulturedTheoryAttribute that support CalleeType and ConditionMemberNames, matching the pattern of the existing ConditionalFact/ConditionalTheory attributes.

These derive from CulturedFactAttribute/CulturedTheoryAttribute (xunit v3 only) and use the existing ConditionalTestDiscoverer.EvaluateSkipConditions to set Skip at construction time. Constructors include [CallerFilePath] and [CallerLineNumber] source information parameters to avoid xUnit3003 errors.

• New attributes in Microsoft.DotNet.XUnitV3Extensions/src/:
  • CulturedConditionalFactAttribute — extends CulturedFactAttribute
  • CulturedConditionalTheoryAttribute — extends CulturedTheoryAttribute
• Tests in CulturedConditionalAttributeTests.cs: skip state validation, property exposure (CalleeType, ConditionMemberNames, Cultures), theory data passthrough, culture verification via CultureInfo.CurrentCulture

[CulturedConditionalFact(new[] { "en-US", "fr-FR" }, typeof(MyTests), new[] { nameof(IsSupported) })]
public void RunsPerCultureWhenConditionMet() { }

[CulturedConditionalTheory(new[] { "en-US", "ja-JP" }, typeof(MyTests), new[] { nameof(IsSupported) })]
[InlineData(42)]
public void TheoryRunsPerCultureWhenConditionMet(int value) { }

To double check:

• The right tests are in and the right validation has happened. Guidance: https://github.com/dotnet/arcade/blob/main/Documentation/Validation.md

[Copilot]

Pull request overview

Adds xUnit v3 cultured conditional test attributes so tests can combine culture-specific execution with existing conditional skip evaluation.

Changes:

• Adds CulturedConditionalFactAttribute.
• Adds CulturedConditionalTheoryAttribute.
• Adds tests validating skip behavior, exposed properties, theory data passthrough, and culture selection.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Microsoft.DotNet.XUnitV3Extensions/src/CulturedConditionalFactAttribute.cs	Adds the cultured conditional fact attribute implementation.
src/Microsoft.DotNet.XUnitV3Extensions/src/CulturedConditionalTheoryAttribute.cs	Adds the cultured conditional theory attribute implementation.
src/Microsoft.DotNet.XUnitV3Extensions/tests/CulturedConditionalAttributeTests.cs	Adds xUnit v3 tests covering the new attributes.

[akoeplinger]

@AndriySvyryd won't this potentially cause issues if the tests run concurrently with other tests and the process culture is changed?

[AndriySvyryd]

That would be an issue in XUnit.
https://github.com/xunit/xunit/blob/main/src/xunit.v3.core/ObjectModel/CulturedXunitTestCase.cs#L103 sets it globally, but in V2 it was set only for a specific thread:
https://github.com/xunit/xunit/blob/main/src/xunit.v2.tests/TestUtility/CultureAwareTesting/CulturedXunitTestCase.cs#L53
This looks like a deliberate change, so there must be some mechanism to isolate the other tests.
@bradwilson Would you like to weigh it?

[bradwilson]

Yeah, these should be using Thread.CurrentCulture and Thread.CurrentUICulture instead of CultureInfo. I'm not sure why that changed... 🤔

[bradwilson]

Actually, using CultureInfo.CurrentCulture is correct according to the docs: https://learn.microsoft.com/dotnet/api/system.globalization.cultureinfo.currentculture

Gets or sets the CultureInfo object that represents the culture used by the current thread and task-based asynchronous operations.

[bradwilson]

I'm not sure what the purpose of these classes are, since [CulturedFact] and [CulturedTheory] in v3 already support conditional skipping via SkipUnless or SkipWhen.

[bradwilson]

Also, you're missing source information constructor parameters, which should be causing xUnit3003 to trigger.

[AndriySvyryd]

I'm not sure what the purpose of these classes are, since [CulturedFact] and [CulturedTheory] in v3 already support conditional skipping via SkipUnless or SkipWhen.

SkipUnless and SkipWhen only support public static properties on the test class. This attribute (and the others like https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.XUnitExtensions.Shared/Attributes/ConditionalFactAttribute.cs) allows to reference any static member on any type. It also allows to specify multiple conditions.

[bradwilson]

SkipType allows reference to other types, but it is true that we only support properties. If you need to support methods, that would make sense.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• xunit.net
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)