Refactor PGP verification to use inheritance-based architecture#16495
Draft
Refactor PGP verification to use inheritance-based architecture#16495
Conversation
Co-authored-by: ellahathaway <67609881+ellahathaway@users.noreply.github.com>
Co-authored-by: ellahathaway <67609881+ellahathaway@users.noreply.github.com>
Co-authored-by: ellahathaway <67609881+ellahathaway@users.noreply.github.com>
…andling Co-authored-by: ellahathaway <67609881+ellahathaway@users.noreply.github.com>
Co-authored-by: ellahathaway <67609881+ellahathaway@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add validation for detached signatures in SignCheck
Add detached PGP signature verification for .sig files
Feb 2, 2026
ellahathaway
requested changes
Feb 2, 2026
Member
ellahathaway
left a comment
There was a problem hiding this comment.
@copilot - Instead of creating a helper class, please rename LinuxPackageVerifier to PgpVerifier, and update all references accordingly. Then have SigVerifier inherit from PgpVerifier.
Copilot stopped work on behalf of
ellahathaway due to an error
February 2, 2026 21:33
Copilot stopped work on behalf of
ellahathaway due to an error
February 2, 2026 22:47
Co-authored-by: ellahathaway <67609881+ellahathaway@users.noreply.github.com>
Copilot
AI
changed the title
Add detached PGP signature verification for .sig files
Refactor PGP verification to use inheritance-based architecture
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
PgpVerificationHelperstatic class withPgpVerifierabstract base class to provide cleaner inheritance hierarchy for PGP signature verification.Architecture Changes
New
PgpVerifierabstract base class (extendsFileVerifier)VerifyPgpSignature()as public static method for shared useGetSignatureDocumentAndSignableContent()contractSigVerifierinheritancePgpVerifierinstead ofFileVerifier.sigfilesLinuxPackageVerifiercompositionArchiveVerifier(required for archive unpacking)PgpVerifier.VerifyPgpSignature()static methodRpmVerifierandDebVerifiersubclassesWorks around C# single inheritance limitation by providing static method for classes that cannot inherit from
PgpVerifier.To double check:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.