Skip to content

[tests] Fix UrlEscaping_Bug43411 to actually run and assert correctly #11523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathanpeppers wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

[tests] Fix UrlEscaping_Bug43411 to actually run and assert correctly #11523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...oid-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidMessageHandlerIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ public void Properties_Invalid ()
}

[Test]
void UrlEscaping_Bug43411 ()
public void UrlEscaping_Bug43411 ()
{
UrlEscaping_TestUrl ($"http://{TestHost}/?example=value%20_value", "#1");
UrlEscaping_TestUrl ($"http://{TestHost}/?query=anna%20%26%20lotte&param2=true", "#2");
Expand All @@ -239,7 +239,10 @@ void UrlEscaping_TestUrl (string url, string messagePrefix)
var request = new HttpRequestMessage (HttpMethod.Get, url);

client.SendAsync (request, HttpCompletionOption.ResponseHeadersRead).Wait ();
Assert.AreEqual (url, request.RequestUri.ToString (), $"{messagePrefix}-1");
// Use AbsoluteUri rather than ToString(): ToString() returns the
// "human-readable" form and unescapes safe characters like %20,
// while AbsoluteUri preserves the canonical percent-encoding.
Assert.AreEqual (url, request.RequestUri.AbsoluteUri, $"{messagePrefix}-1");
Assert.IsNull (failed, $"{messagePrefix}-2");
} finally {
listener.Abort ();
Expand Down